Support extensions in useSubscription #11854
Conversation
|
@jcostello-atlassian: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
👷 Deploy request for apollo-client-docs pending review.Visit the deploys page to approve it
|
🦋 Changeset detectedLatest commit: 8b9bc7a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This adds optional support for extensions in useSubscription following the graphql-ws spec: https://github.com/enisdenjo/graphql-ws/blob/master/PROTOCOL.md
jcostello-atlassian
force-pushed
the
jcostello2/subscription-extensions
branch
from
7a9d21a
to
8b9bc7a
Compare
|
Thank you for the PR! I'm gonna be honest, the two of us have the worst timing: I'm in the middle of rewriting that hook right now (you can see the current progress over here: https://github.com/apollographql/apollo-client/pull/11511/files#diff-aa77d592927baae676cedc8e3fda943bf63744e885b0328371c6ebd9d18aebdb) because previously it was breaking multiple rules of hooks and I can't find a minimal angle of fixing it. Looking at this, I'm already happy that most of your changes are in the core. Phew 😅 I just wanted to let you know - we'll look at this, but before that we have to figure out #11511, I hope that's okay! |
|
No, please keep it open - you put a lot of work into this and I believe we'll be able to salvage most of it. It just might take a while :) |
This adds optional support for extensions in useSubscription following the graphql-ws spec:
https://github.com/enisdenjo/graphql-ws/blob/master/PROTOCOL.md