Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update the copyright notice #2393

Closed
wants to merge 1 commit into from

Conversation

honzajavorek
Copy link

You may want to update this number unless the project is inactive. It's a small thing, but AFAIK (IANAL tho), the year marks a start of the period after which the work becomes public domain.

@honzajavorek honzajavorek changed the title Update the copyright notice chore: Update the copyright notice Mar 26, 2024
@B4nan
Copy link
Member

B4nan commented Mar 26, 2024

Last time we were discussing this, someone (was it @jirimoravcik? maybe it was even in a different company 🙃) said it's actually a good thing to have the old number there, as it represents when the project started.

Personally, I never update this number, and I recall some frameworks used to do that and stopped as well, as it only adds clutter without any value.

So if we want to change this, I would be rather in favor of removing the number completely (or keeping the old value which represents the start). Checked a few larger projects and none of them had the year in their license file.

Thoughts @jancurn @mtrunkat?

@jancurn
Copy link
Member

jancurn commented Mar 26, 2024

This is really a legal question cc @mnmkng

@honzajavorek
Copy link
Author

as it represents when the project started

I've also seen things like Copyright 2018-2024 Apify Technologies s.r.o. And I'm sorry for summoning this bikeshedding demon upon you! I'm going through the tutorials and Crawlee claims to be open source, forever, so being a curious person, in light of recent re-licensing of Redis etc., I've checked what kind of license you're using. Then I spotted the number, recalled my good old Oracle times (spent way too much time with licenses) and couldn't restrain myself to this little update.

@B4nan
Copy link
Member

B4nan commented Mar 26, 2024

From what I read, it should note the start of the copyright notice, the license itself does not require a year at all.

https://opensource.stackexchange.com/questions/5778/why-do-licenses-such-as-the-mit-license-specify-a-single-year

And, on a different page, I found that copyright is valid till the author dies (plus a few years), so this is not really important nowadays (but pretty much everybody starts those answers with "if I understood this right..." 🙃).

@B4nan B4nan added the t-tooling Issues with this label are in the ownership of the tooling team. label May 22, 2024
@B4nan
Copy link
Member

B4nan commented May 22, 2024

so what about this one, merge or not? i would keep what we have, but no strong opinions really

@mnmkng
Copy link
Member

mnmkng commented May 23, 2024

I don't think the change is needed.

@honzajavorek
Copy link
Author

I'll close this. The current number doesn't cause any real issues for the project and doesn't bring any immediate risks. I feel bad that this PR takes attention and time of so many people.

@honzajavorek honzajavorek deleted the patch-1 branch May 23, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-tooling Issues with this label are in the ownership of the tooling team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants