-
Notifications
You must be signed in to change notification settings - Fork 7.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature:Configurable summarySetBlackList to set monitoring blacklist. #2165
base: master
Are you sure you want to change the base?
Conversation
/** | ||
* Base implementation of {@link MetricsProvider}.<br> | ||
* 提供默认的实现,当前包含summarySet黑名单功能。 | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use English, instead of Chinese
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
I cannot understand the intention of this PR clearly. From the description, I guess
|
it wants to solve metrics(write_per_namespace,read_per_namespace) which is too expensive.
|
Perhaps it's a more universal and maintainable solution to remove the metric monitoring when the / path node is deleted. Regarding this PR, I will make some further modifications. |
Issue:
Root Cause:
Solution:
Provide a new version of the ZK server that supports configurable Namespace monitoring.