Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fixes workflow Applitools Cypress #28566

Merged
merged 3 commits into from
May 20, 2024
Merged

fix: Fixes workflow Applitools Cypress #28566

merged 3 commits into from
May 20, 2024

Conversation

geido
Copy link
Member

@geido geido commented May 17, 2024

SUMMARY

Applitools Cypress wasn't running due to specs not being found. This PR does the followings:

  • Moves the Applitools tests in their own dir as these are visual regression tests and not e2e
  • Fixes the paths

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N.A.

TESTING INSTRUCTIONS

The workflow should run

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@github-actions github-actions bot added the github_actions Pull requests that update GitHub Actions code label May 17, 2024
@rusackas rusackas added the review:checkpoint Last PR reviewed during the daily review standup label May 17, 2024
@geido geido merged commit e954360 into master May 20, 2024
32 of 33 checks passed
@john-bodley john-bodley removed the review:checkpoint Last PR reviewed during the daily review standup label May 20, 2024
@rusackas rusackas deleted the geido/fix/applitools-cypress-no-specs branch May 20, 2024 18:48
Vitor-Avila pushed a commit to Vitor-Avila/superset that referenced this pull request May 28, 2024
@geido @Vitor-Avila
fix: Fixes workflow Applitools Cypress (apache#28566)
ee43705
EnxDev pushed a commit to EnxDev/superset that referenced this pull request May 31, 2024
@geido @EnxDev
fix: Fixes workflow Applitools Cypress (apache#28566)
8c950ee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rusackas rusackas rusackas approved these changes

@villebro villebro Awaiting requested review from villebro villebro is a code owner

@eschutho eschutho Awaiting requested review from eschutho eschutho is a code owner

@betodealmeida betodealmeida Awaiting requested review from betodealmeida betodealmeida is a code owner

@nytai nytai Awaiting requested review from nytai nytai is a code owner

@mistercrunch mistercrunch Awaiting requested review from mistercrunch mistercrunch is a code owner

@craig-rueda craig-rueda Awaiting requested review from craig-rueda craig-rueda is a code owner

@john-bodley john-bodley Awaiting requested review from john-bodley john-bodley is a code owner

@kgabryje kgabryje Awaiting requested review from kgabryje kgabryje is a code owner

@dpgaspar dpgaspar Awaiting requested review from dpgaspar dpgaspar is a code owner

@jinghua-qa jinghua-qa Awaiting requested review from jinghua-qa jinghua-qa is a code owner

Assignees
No one assigned
Labels
github_actions Pull requests that update GitHub Actions code size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@geido @rusackas @john-bodley