feat: unpack payload into log function #28521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
logging
Pass down the payload dict (merged from the ? querystring and POST data, depending on context) and pass it to the log function. In my specific case, I was looking to do analysis on around how much of the calls to `ChartDataRestApi.data` are using "force=true", and realize while this is in context, it doesn't flow through my current logger. By adding this one line of code, it should allow for many more (in fact ALL querystring and POST payload) parameters to flow through the logger. From there custom loggers can have access to much more context. Note that by default, the loggers we have won't do anything with the new arguments passed, and essentially flush it.
|
POST payload can have sensitive data |
Totally - though that variable is just passed to the logger, not logged. Actually let me improve this a bit. I'll pass more explicitely a |
|
@dpgaspar I took a different approach, let me know what you think |
dpgaspar
approved these changes
May 22, 2024
| "database_id": None, | ||
| "user_id": 2, | ||
| "duration": 5558756000, | ||
| "curated_payload": {}, |
There was a problem hiding this comment.
would be nice to actually have tests with the curated payload
Vitor-Avila
pushed a commit
to Vitor-Avila/superset
that referenced
this pull request
May 28, 2024
john-bodley
pushed a commit
to john-bodley/superset
that referenced
this pull request
May 29, 2024
john-bodley
pushed a commit
to john-bodley/superset
that referenced
this pull request
May 29, 2024
EnxDev
pushed a commit
to EnxDev/superset
that referenced
this pull request
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unpack the payload (merged from the ? querystring and POST data, depending on context) and pass it to the log function. In my specific case, I was looking to do analysis on around how much of the calls to
ChartDataRestApi.dataare using "force=true", and realize while this is in context, it doesn't flow through my current logger. By adding this one line of code, it should allow for many more (in fact ALL querystring and POST payload) parameters to flow through the logger. From there custom loggers can have access to much more context. Note that by default, the loggers we have won't do anything with the new arguments passed, and essentially flush it.