[SPARK-48215][SQL] Extending support for collated strings on date_format expression #46561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nikolamand-db @uros-db @stefankandic @mihailom-db Please review :) |
sql/core/src/test/scala/org/apache/spark/sql/CollationStringExpressionsSuite.scala
Outdated
Show resolved
Hide resolved
uros-db
reviewed
May 13, 2024
sql/core/src/test/scala/org/apache/spark/sql/CollationStringExpressionsSuite.scala
Outdated
Show resolved
Hide resolved
sql/core/src/test/scala/org/apache/spark/sql/CollationStringExpressionsSuite.scala
Outdated
Show resolved
Hide resolved
sql/core/src/test/scala/org/apache/spark/sql/CollationStringExpressionsSuite.scala
Outdated
Show resolved
Hide resolved
HyukjinKwon
changed the title
uros-db
reviewed
May 14, 2024
sql/core/src/test/scala/org/apache/spark/sql/CollationSQLExpressionsSuite.scala
Show resolved
Hide resolved
nikolamand-db
approved these changes
May 15, 2024
|
@cloud-fan please take a look and merge :) |
cloud-fan
approved these changes
May 22, 2024
|
thanks, merging to master! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
We are extending support for collated strings on date_format function, since currently it throws DATATYPE_MISSMATCH exception when collated strings are passed as "format" parameter. https://docs.databricks.com/en/sql/language-manual/functions/date_format.html
Why are the changes needed?
Exception is thrown on invocation when collated strings are passed as arguments to date_format.
Does this PR introduce any user-facing change?
No user facing changes, extending support.
How was this patch tested?
Tests are added with this PR.
Was this patch authored or co-authored using generative AI tooling?
No.