Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support parsing Oracle Create Outline SQL #31283

Merged
merged 3 commits into from
May 19, 2024
Merged

Support parsing Oracle Create Outline SQL #31283

merged 3 commits into from
May 19, 2024

Conversation

ThanoshanMV
Copy link
Member

@ThanoshanMV ThanoshanMV commented May 18, 2024 •
edited

Fixes #27079

Changes proposed in this pull request:

  • Support parsing Oracle Create Outline SQL

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.

@strongduanmu
Copy link
Member

Hi @ThanoshanMV, can you execute ./mvnw spotless:check -Pcheck -T1C on your local machine?

@ThanoshanMV ThanoshanMV added this to the 5.5.1 milestone May 19, 2024
@ThanoshanMV ThanoshanMV marked this pull request as ready for review May 19, 2024 05:16
strongduanmu
strongduanmu approved these changes May 19, 2024
View reviewed changes
Copy link
Member

@strongduanmu strongduanmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, merged.

@strongduanmu strongduanmu merged commit fb0d1d4 into apache:master May 19, 2024
141 checks passed
@ThanoshanMV ThanoshanMV deleted the 27079 branch May 19, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strongduanmu strongduanmu strongduanmu approved these changes

Assignees
No one assigned
Labels
db: Oracle in: SQL parse type: enhancement
Projects
None yet
Milestone
5.5.1
Development

Successfully merging this pull request may close these issues.

Support parsing Oracle CREATE OUTLINE sql
2 participants
@ThanoshanMV @strongduanmu