fix seatunnel-issue-6386 and windows specific starter cmd script bug #6735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhilinli123
reviewed
Apr 22, 2024
| command.add(cmd_flink); | ||
| } else { | ||
| System.out.println("Error: Can not determine OS type, abort run !"); | ||
| System.exit(-1); |
There was a problem hiding this comment.
System.exit(-1) is not recommended. The code causes some strange security problems; Throw an exception if there is a problem
wuchunfu
reviewed
May 11, 2024
Comment on lines
+61
to
+62
| // debug | ||
| // System.out.println("OS type:"+local_os_type); |
There was a problem hiding this comment.
@GangLiCN Please delete these useless codes
wuchunfu
reviewed
May 11, 2024
Comment on lines
+134
to
+135
| // debug | ||
| // System.out.println("Whole command string:" + command.toString()); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
fix seatunnel-issue-6386 and windows specific starter cmd script bug
Does this PR introduce any user-facing change?
No
How was this patch tested?
Added java unit test cases.
Check list
New License Guide
release-note.