[Feature][Connector-V2] Support TableSourceFactory/TableSinkFactory on http #5816
Conversation
jackyyyyyssss
changed the title
There was a problem hiding this comment.
Please change getProducedType to getProducedCatalogTables in HttpSource. https://github.com/apache/seatunnel/pull/5816/files#diff-7c704c6a3927123b31b41483102f286339da3832309810496f19410c2548f06fR153
done PTAL |
| public void setTypeInfo(SeaTunnelRowType seaTunnelRowType) { | ||
| this.seaTunnelRowType = seaTunnelRowType; | ||
| public String getPluginName() { | ||
| return "Http"; |
There was a problem hiding this comment.
I think you can use CONNECTOR_IDENTITY to replace Http now.
| @@ -49,7 +61,6 @@ public OptionRule.Builder getHttpBuilder() { | |||
| .optional(HttpConfig.FORMAT) | |||
| .optional(HttpConfig.JSON_FIELD) | |||
| .optional(HttpConfig.CONTENT_FIELD) | |||
| .conditional(HttpConfig.METHOD, HttpRequestMethod.POST, HttpConfig.BODY) | |||
There was a problem hiding this comment.
Because when using the params parameter, the post method is also used without a body
There was a problem hiding this comment.
Yes, And you need add HttpConfig.BODY use .optional(HttpConfig.BODY). Otherwise, the body parameter will be lost.
There was a problem hiding this comment.
done PTAL @EricJoy2048
…n http (apache#5816) --------- Co-authored-by: 80597928 <673421862@qq.com>
Purpose of this pull request
#5807 #5651 [Feature][Connector-V2] Support TableSourceFactory/TableSinkFactory on http
Does this PR introduce any user-facing change?
How was this patch tested?
improve current e2e test
Check list
New License Guide
release-note.