support clone latest snapshot #3287
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wwj6591812
force-pushed
the
support_clone_latest_snapshot_0429
branch
from
bd32ebd
to
b67e04e
Compare
tsreaper
reviewed
May 13, 2024
paimon-flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/action/CloneAction.java
Outdated
Show resolved
Hide resolved
...k/paimon-flink-common/src/main/java/org/apache/paimon/flink/clone/CloneFileInfoTypeInfo.java
Outdated
Show resolved
Hide resolved
...link/paimon-flink-common/src/main/java/org/apache/paimon/flink/clone/CloneSourceBuilder.java
Outdated
Show resolved
Hide resolved
...link/paimon-flink-common/src/main/java/org/apache/paimon/flink/clone/CloneSourceBuilder.java
Outdated
Show resolved
Hide resolved
...imon-flink-common/src/main/java/org/apache/paimon/flink/clone/PickFilesForCloneOperator.java
Outdated
Show resolved
Hide resolved
paimon-core/src/main/java/org/apache/paimon/clone/CopyFileUtils.java
Outdated
Show resolved
Hide resolved
paimon-core/src/main/java/org/apache/paimon/clone/CopyFileUtils.java
Outdated
Show resolved
Hide resolved
paimon-core/src/main/java/org/apache/paimon/clone/CopyFileUtils.java
Outdated
Show resolved
Hide resolved
paimon-core/src/main/java/org/apache/paimon/clone/CloneFileInfo.java
Outdated
Show resolved
Hide resolved
...nk/paimon-flink-common/src/main/java/org/apache/paimon/flink/clone/SnapshotHintOperator.java
Outdated
Show resolved
Hide resolved
wwj6591812
force-pushed
the
support_clone_latest_snapshot_0429
branch
from
b67e04e
to
034753f
Compare
tsreaper
reviewed
May 15, 2024
Comment on lines
+67
to
+68
| + "--target_database <target_database_name> " | ||
| + "--target_table <target_table_name> " |
There was a problem hiding this comment.
target_database and target_table are also optional.
Comment on lines
+74
to
+76
| if (!sourceCatalogConfig.isEmpty()) { | ||
| this.sourceCatalogConfig = sourceCatalogConfig; | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (!sourceCatalogConfig.isEmpty()) { | |
| this.sourceCatalogConfig = sourceCatalogConfig; | |
| } | |
| this.sourceCatalogConfig = sourceCatalogConfig; |
Comment on lines
+81
to
+83
| if (!targetCatalogConfig.isEmpty()) { | ||
| this.targetCatalogConfig = targetCatalogConfig; | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (!targetCatalogConfig.isEmpty()) { | |
| this.targetCatalogConfig = targetCatalogConfig; | |
| } | |
| this.targetCatalogConfig = targetCatalogConfig; |
|
|
||
| /** | ||
| * Pick the tables to be cloned based on the user input parameters. The record type of the build | ||
| * DataStream is Tuple2. The left element is the identifier of source table and the right element is |
There was a problem hiding this comment.
Suggested change
| * DataStream is Tuple2. The left element is the identifier of source table and the right element is | |
| * DataStream is {@link Tuple2}. The left element is the identifier of source table and the right element is |
Comment on lines
+78
to
+80
| } catch (Exception e) { | ||
| // ignore | ||
| } |
There was a problem hiding this comment.
Don't igonre exceptions. Throw it out.
|
|
||
| import org.apache.paimon.table.sink.ChannelComputer; | ||
|
|
||
| /** SnapshotHintChannelComputer. */ |
There was a problem hiding this comment.
Write meaningful comments please.
Comment on lines
+41
to
+42
| * When the files copy finished of a table, then create snapshot hint, it means that this table can | ||
| * be used now. |
There was a problem hiding this comment.
Suggested change
| * When the files copy finished of a table, then create snapshot hint, it means that this table can | |
| * be used now. | |
| * Creates snapshot hint files after copying a table. |
| LOG.info( | ||
| "Skipping target file {} because it already exists and has the same size.", | ||
| targetPath); | ||
| return; |
There was a problem hiding this comment.
Consider copying the whole database. There are two tables in this database. All files of table A has been copied, so no record about table A will be sent to SnapshotHintOperator. Snapshot hint files of table A will not be created.
| + " dt STRING," | ||
| + " PRIMARY KEY (k, dt, hh) NOT ENFORCED" | ||
| + ") PARTITIONED BY (dt, hh) WITH (" | ||
| + " 'write-only' = 'true'," |
| prepareTable( | ||
| Arrays.asList("dt", "hh"), | ||
| Arrays.asList("dt", "hh", "k"), | ||
| Collections.singletonMap(CoreOptions.WRITE_ONLY.key(), "true")); |
JingsongLi
reviewed
May 16, 2024
| Run the following command to submit a clone job for the table's latest Snapshot. | ||
|
|
||
| ```bash | ||
| CALL sys.clone('source_warehouse', 'source_database', 'source_table', '', 'target_warehouse', 'target_database', 'target_table', '', '') |
There was a problem hiding this comment.
Just support Flink 1.19. Using named argurment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #xxx
Tests
API and Format
Documentation