[compaction] Filter out invalid splits to improve flink database compaction efficiency #3233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhourui999
force-pushed
the
filter_commit_msg
branch
from
b580c76
to
0ed2e7b
Compare
zhourui999
changed the title
zhourui999
force-pushed
the
filter_commit_msg
branch
from
3165576
to
367df6e
Compare
JingsongLi
reviewed
Apr 20, 2024
| CommitMessageImpl commitMessage = | ||
| (CommitMessageImpl) | ||
| committable.wrappedCommittable(); | ||
| return !commitMessage.compactIncrement().isEmpty(); |
There was a problem hiding this comment.
just use CommitMessageImpl.isEmpty?
zhourui999
force-pushed
the
filter_commit_msg
branch
from
349d421
to
6c75f2c
Compare
zhourui999
force-pushed
the
filter_commit_msg
branch
from
52284e5
to
4ae3dce
Compare
zhourui999
changed the title
JingsongLi
reviewed
Apr 29, 2024
| } | ||
| return dataSplit.dataFiles().stream() | ||
| .map(DataFileMeta::level) | ||
| .anyMatch(level -> level != maxLevel); |
JingsongLi
reviewed
Apr 29, 2024
| .filter( | ||
| split -> { | ||
| DataSplit dataSplit = (DataSplit) split; | ||
| if (dataSplit.dataFiles().isEmpty()) { |
There was a problem hiding this comment.
Why not care before files?
JingsongLi
requested changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #xxx
Filter out invalid splits to improve flink database compaction efficiency
(1) Referring to the pickFullComparison method of CompactStrategy, filter out whether dataFiles is empty or all files in dataFiles are at the max-level
Tests
API and Format
Documentation