feat(core/types): add new buffer util fns #4598
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have implemented the split fn now. I would like to ask, how can I test if my code is okay? Are there any areas that need to be supplemented with unit tests? Thank you for taking the time to assist me with this task. |
Xuanwo
reviewed
May 11, 2024
We can add test cases in the |
Xuanwo
reviewed
May 14, 2024
| /// The portion before the index is stored in the `left` object, while the portion | ||
| /// after the index is removed from the current object (`self`). | ||
| #[inline] | ||
| pub fn split_to(&mut self, at: usize) -> Self { |
There was a problem hiding this comment.
Hi, would you like to add test cases for them?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #4593