[WIP] Rewrite cpp binding by pimpl #3584
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xuanwo
reviewed
Nov 14, 2023
| * @brief The mode of the entry | ||
| */ | ||
| enum class EntryMode { | ||
| kFile = 0, |
There was a problem hiding this comment.
Why we need to add a k prefix here?
There was a problem hiding this comment.
tag it as a enum，distinguish it from macro
There was a problem hiding this comment.
that totally makes sense for enum, but this in an enum class so it is namespaced which should be totally sufficient.
| const noexcept; | ||
|
|
||
| private: | ||
| struct Rep; |
There was a problem hiding this comment.
representative，it's a common cpp impl name
Signed-off-by: Jack Drogon <jack.xsuperman@gmail.com>
Signed-off-by: Jack Drogon <jack.xsuperman@gmail.com>
Signed-off-by: Jack Drogon <jack.xsuperman@gmail.com>
Signed-off-by: Jack Drogon <jack.xsuperman@gmail.com>
Signed-off-by: Jack Drogon <jack.xsuperman@gmail.com>
Signed-off-by: Jack Drogon <jack.xsuperman@gmail.com>
Signed-off-by: Jack Drogon <jack.xsuperman@gmail.com>
Signed-off-by: Jack Drogon <jack.xsuperman@gmail.com>
JackDrogon
force-pushed
the
refactor/rewrite_cpp_binding_by_pimpl
branch
from
625bf93
to
cf59ad8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.