Issues/OAK-10675 #1385
Issues/OAK-10675 #1385
Conversation
…nd add license to new files
| import java.util.Optional; | ||
| import java.util.Properties; | ||
|
|
||
| public class AzureDataStoreAccessManager { |
There was a problem hiding this comment.
Public methods of this class do not resolve access rights. This class rather provides CloudBlobContainer . I would rename it accordingly.
There was a problem hiding this comment.
Renamed to AzureBlobContainerProvider
| guava, | ||
| jsr305 | ||
| jsr305, |
There was a problem hiding this comment.
I'm very concerned about the amount of embeds here. Is this really needed? It will make the nundle bigger, and will make updates harder...
There was a problem hiding this comment.
At least JSR305 is never necessary at run time AFAIK. It is only annotations relevant at compile time.
There was a problem hiding this comment.
@reschke, we are using azure-identity library for migration to service principals from access key based authentication in azure. All these dependencies came transitively from azure-identity. I initially tried marking some of them as optional which helped in resolving the bundle to active state but when I configured the component to use service principals, it failed with NoClassDefFoundError exceptions meaning that they were indeed required at runtime and cannot be marked as optional.
Attaching the file of errors that I got and the corresponding dependency embedded.
dependencies_list.pdf
There was a problem hiding this comment.
I just wanted to make sure we know what we do :-)
Added service principal support in oak-blob-cloud-azure