Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spark: Use bulk deletes in rewrite manifests action #10343

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Spark: Use bulk deletes in rewrite manifests action #10343

wants to merge 1 commit into from
+27 −21

Conversation

amogh-jahagirdar
Copy link
Contributor

This change uses bulk deletes when possible when cleaning up files as part of any failure or as part of the staging logic for v1 tables.

@github-actions github-actions bot added the spark label May 17, 2024
nastra
nastra approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@nastra nastra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the change makes sense to me. I wonder if we should have a variation of SparkCleanupUtil.deleteFiles for this, where we have some additional logging/exception handling when e.g. bulk deletes are only partially applied (inside SparkCleanupUtil.bulkDelete

dramaticlly
dramaticlly approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@dramaticlly dramaticlly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also noticed that there's deleteFiles in BaseSparkAction which batch files by group of 10k, but I think it's more for snapshot expiration or purge

@amogh-jahagirdar amogh-jahagirdar force-pushed the rewrite-manifests-bulk-deletes branch 2 times, most recently from ece6a88 to f51bf8e Compare June 9, 2024 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nastra nastra nastra approved these changes

@dramaticlly dramaticlly dramaticlly approved these changes

Assignees
No one assigned
Labels
spark
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@amogh-jahagirdar @nastra @dramaticlly