Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid multiple hops to the same destination #3944 #3947

Merged
merged 1 commit into from
May 27, 2024
Merged

Conversation

nadment
Copy link
Contributor

@nadment nadment commented May 16, 2024

No description provided.

@nadment nadment added this to the 2.9 milestone May 16, 2024
@nadment nadment linked an issue May 16, 2024 that may be closed by this pull request
@hansva
Copy link
Contributor

hansva commented May 17, 2024

These changes do not work on my system, The Funny thing is I can not reproduce the original issue...
When I split a hop it correctly deletes the original hop.
With these changes I no longer get the ability to split hops

second note, maybe we should fix the typo in "insetAction"

@hansva hansva marked this pull request as draft May 17, 2024 09:22
Fix typo method name 'insetAction'
@hansva
Copy link
Contributor

hansva commented May 17, 2024

re-tested and seems OK, but let us lift this to 2.10 gives us a bit more time to test it

@nadment nadment modified the milestones: 2.9, 2.10 May 17, 2024
@hansva hansva marked this pull request as ready for review May 27, 2024 13:13
@hansva hansva merged commit 0df4d9a into apache:main May 27, 2024
2 checks passed
@github-actions github-actions bot removed this from the 2.10 milestone May 27, 2024
@nadment nadment deleted the 3944 branch May 30, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Multiple hops to the same action in a workflow
2 participants