Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIVE-28250: Add tez.task-specific configs into whitelist to modify at session level #5242

Merged
merged 1 commit into from
May 28, 2024

Conversation

Aggarwal-Raghav
Copy link
Contributor

What changes were proposed in this pull request?

HIVE-28250: Refer the JIRA for error message

Why are the changes needed?

For easier debugging tez jobs in cluster. tez.task-specific configs are used for debugging/profiling a particular vertex but we cannot set them at session level.

Does this PR introduce any user-facing change?

NO

Is the change a dependency upgrade?

NO

How was this patch tested?

On local machine (single node setup)

@Aggarwal-Raghav
Copy link
Contributor Author

There can be 2 approaches:

  1. Replace exisiting regex: tez\\.task\\..* -> tez\\.task.*
  2. Add a new regex: tez\\.task\\-.*

PR contains approach 2.

Copy link

sonarcloud bot commented May 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Member

@deniskuzZ deniskuzZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aggarwal-Raghav
Copy link
Contributor Author

Thanks for the review @deniskuzZ , much appreciated.

@deniskuzZ deniskuzZ merged commit 3be197e into apache:master May 28, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants