-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HIVE-28238: Open Hive transaction only for ACID resources #5216
Merged
+1,199
−1,225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deniskuzZ
requested review from
kasakrisz
and removed request for
miklosgergely and
klcopp
April 29, 2024 08:14
asf-ci-hive
added
tests pending
tests passed
and removed
tests passed
tests pending
labels
Apr 29, 2024
Is there an apache jira about this change? |
kasakrisz
reviewed
Apr 30, 2024
...etastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java
Outdated
Show resolved
Hide resolved
deniskuzZ
changed the title
Open Hive ACID txn only for transactional resources
HIVE-28238: Open Hive ACID txn only for transactional resources
Apr 30, 2024
|
asf-ci-hive
added
tests pending
tests failed
and removed
tests passed
tests pending
labels
May 5, 2024
deniskuzZ
commented
May 26, 2024
@@ -147,8 +146,7 @@ private String getExpandedText(List<FieldSchema> imposedSchema, ASTNode select, | |||
return expandedText; | |||
} | |||
|
|||
private List<FieldSchema> getPartitionColumns(List<FieldSchema> imposedSchema, ASTNode select, TableName viewName, | |||
List<String> partitionColumnNames) throws SemanticException { | |||
private List<FieldSchema> getPartitionColumns(List<String> partitionColumnNames) throws SemanticException { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
refactor: unused params
asf-ci-hive
added
tests pending
tests unstable
tests passed
and removed
tests failed
tests pending
tests unstable
labels
May 26, 2024
kasakrisz
reviewed
Jun 3, 2024
ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java
Outdated
Show resolved
Hide resolved
ql/src/java/org/apache/hadoop/hive/ql/ddl/view/create/CreateMaterializedViewDesc.java
Show resolved
Hide resolved
ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java
Outdated
Show resolved
Hide resolved
ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java
Outdated
Show resolved
Hide resolved
Quality Gate passedIssues Measures |
kasakrisz
approved these changes
Jun 4, 2024
deniskuzZ
changed the title
HIVE-28238: Open Hive ACID txn only for transactional resources
HIVE-28238: Open Hive transaction only for ACID resources
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Open ACID txn only when transactional resources are present in a query
Why are the changes needed?
Backend db calls optimization
Does this PR introduce any user-facing change?
No
Is the change a dependency upgrade?
No
How was this patch tested?
mvn test -Dtest=ITestDbTxnManager -Dtest.metastore.db=postgres