Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test on JDK 22 and update JDK 23 EA #2072

Merged
merged 1 commit into from
Jun 3, 2024
Merged

Test on JDK 22 and update JDK 23 EA #2072

merged 1 commit into from
Jun 3, 2024

Conversation

Goooler
Copy link
Member

@Goooler Goooler commented Apr 3, 2024

No description provided.

@Goooler
Copy link
Member Author

Goooler commented Apr 3, 2024

Ooops, this may need Gradle 8.8

@Goooler Goooler marked this pull request as draft April 3, 2024 01:54
@codecov-commenter
Copy link

codecov-commenter commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.5877%. Comparing base (6cd477b) to head (99ef0a7).
Report is 74 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##               master      #2072        +/-   ##
==================================================
- Coverage     68.5957%   68.5877%   -0.0080%     
- Complexity      29233      29314        +81     
==================================================
  Files            1426       1426                
  Lines          113494     113618       +124     
  Branches        19548      19605        +57     
==================================================
+ Hits            77852      77928        +76     
- Misses          29088      29128        +40     
- Partials         6554       6562         +8     

see 30 files with indirect coverage changes

@daniellansun
Copy link
Contributor

Gradle 8.7 does not support JDK 22 because it still uses Groovy 3.

@paulk-asert
Copy link
Contributor

Gradle 8.7 does not support JDK 22 because it still uses Groovy 3.

Gradle 8.7 uses Groovy 3.0.17. Groovy 3.0.21 embeds ASM 9.6 and hence can read JDK 22 class files. We have additional support for recent JDKs in Groovy 4+. We haven't done any testing to try to determine whether Gradle needs the additional support or is unaffected.

@Goooler Goooler marked this pull request as ready for review June 1, 2024 08:15
@Goooler
Copy link
Member Author

Goooler commented Jun 1, 2024

@paulk-asert PTL

@Goooler Goooler merged commit a019862 into apache:master Jun 3, 2024
18 checks passed
@Goooler Goooler deleted the jdk22 branch June 3, 2024 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants