Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BP-3.1][FLINK-35323][runtime] Fix transform failure when one rule matches multiple schemas #3312

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

yuxiqian
Copy link
Contributor

This closes FLINK-35323.

Currently, Transform module doesn’t support handling multiple tables with different schema within one projection / filtering rule. This is not intended and turns out to be related to incorrectly handled processor caching strategy. Fixing the cache key should resolve this problem.

@yuxiqian
Copy link
Contributor Author

cc @aiwenmo

@yuxiqian yuxiqian changed the title [FLINK-35323][runtime] Fix transform failure when one rule matches multiple schemas [BP-3.1][FLINK-35323][runtime] Fix transform failure when one rule matches multiple schemas May 11, 2024
Copy link
Contributor

@aiwenmo aiwenmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuxiqian
Copy link
Contributor Author

Could @PatrickRen help take a look? Thanks!

Copy link
Contributor

@leonardBang leonardBang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yuxiqian for the fix, LGTM

@leonardBang leonardBang merged commit f4045fb into apache:release-3.1 Jun 3, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants