Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Validator supports automatic switch #14194

Merged
merged 3 commits into from
May 22, 2024

Conversation

aofall
Copy link
Contributor

@aofall aofall commented May 16, 2024

What is the purpose of the change

  1. In the newer versions of Hibernate-validator, the package names of the relevant validation implementation classes have been migrated from javax to jakarta.
    Dubbo has been support new validator with jakarta in feature: support jsr-303 jakarta namespace #9552 , but the setting of default validator is implement with javax, if the user is not configured to use a new validator under the SpringBoot3, an NoClassDefFoundError will be throw.
    If the validator supports automatic switch, this will reduce a lot of configuration processes for users. So Add an adapter that it can automatically switch.

  2. If user fill in any characters into dubbo.provider/consumer.validation configuration that the validation extension not exists, the validation will active the default validator.
    But in the official documentation the parameter type of dubbo.provider.validation and dubbo.consumer.validation is described as Boolean, it's unexpect that user fill in the false parameter.
    Support disabling validation when parameter is 'false' that it is expected the description in document the parameter type is boolean

Brief changelog

  1. Add an adapter for javax and jakarta that it can automatically switch

  2. Support disabling validation when parameter is 'false' that it is expected the description in document the parameter type is boolean

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

Add an adapter for javax and jakarta that it can automatically switch

Support disabling validation when parameter is 'false' that it is expected the description in document the parameter type is boolean
@aofall aofall requested a review from AlbumenJ May 17, 2024 05:36
Copy link

sonarcloud bot commented May 21, 2024

@AlbumenJ AlbumenJ merged commit 8368262 into apache:3.3 May 22, 2024
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants