[feat](nereids)add more rules to eliminate empty relation #34997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
morrySnow
reviewed
May 17, 2024
Comment on lines
54
to
55
| // .when(this::hasEmptyRelationChild) | ||
| // .when(this::canReplaceJoinByEmptyRelation) |
Comment on lines
57
to
58
| if (hasEmptyRelationChild(join) && canReplaceJoinByEmptyRelation(join) | ||
| || bothChildrenEmpty(join)) { |
There was a problem hiding this comment.
use when for better performance
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/EliminateEmptyRelation.java
Outdated
Show resolved
Hide resolved
englefly
force-pushed
the
elimenate_empty_relation
branch
from
7cc367b
to
07ed182
Compare
|
run buildall |
morrySnow
approved these changes
May 21, 2024
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
XieJiann
approved these changes
May 21, 2024
dataroaring
pushed a commit
that referenced
this pull request
May 26, 2024
eliminate empty relations for following patterns: topn->empty sort->empty distribute->empty project->empty
englefly
added a commit
to englefly/incubator-doris
that referenced
this pull request
May 28, 2024
) eliminate empty relations for following patterns: topn->empty sort->empty distribute->empty project->empty (cherry picked from commit 8340f23)
yiguolei
pushed a commit
that referenced
this pull request
May 28, 2024
…branch-2.1 (#35534) eliminate empty relations for following patterns: topn->empty sort->empty distribute->empty project->empty (cherry picked from commit 8340f23) ## Proposed changes Issue Number: close #xxx <!--Describe your changes.--> ## Further comments If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
eliminate empty relations for following patterns:
topn->empty
sort->empty
distribute->empty
project->empty
Issue Number: close #xxx
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...