[fix](multi-catalog)put java udf to custom lib #34990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
wsjz
force-pushed
the
cus_lib
branch
3 times, most recently
from
b95eb0e
to
6eaff89
Compare
|
run buildall |
|
TeamCity be ut coverage result: |
wsjz
force-pushed
the
cus_lib
branch
2 times, most recently
from
d9b6986
to
51aac40
Compare
|
run buildall |
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 41889 ms |
TPC-DS: Total hot run time: 182528 ms |
ClickBench: Total hot run time: 30.89 s |
wsjz
force-pushed
the
cus_lib
branch
3 times, most recently
from
5032555
to
e2e6389
Compare
|
|
|
run buildall |
|
run buildall |
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 41509 ms |
TPC-DS: Total hot run time: 171465 ms |
ClickBench: Total hot run time: 30.55 s |
|
run p0 |
|
run buildall |
|
run buildall |
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 41813 ms |
TPC-DS: Total hot run time: 171249 ms |
ClickBench: Total hot run time: 30.89 s |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 39900 ms |
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 171149 ms |
ClickBench: Total hot run time: 29.72 s |
morningman
approved these changes
May 24, 2024
| @@ -17,6 +17,7 @@ | |||
|
|
|||
| package org.apache.doris.analysis; | |||
|
|
|||
| import okio.Path; | |||
github-actions
bot
added
the
approved
BePPPower
approved these changes
May 24, 2024
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
dataroaring
pushed a commit
that referenced
this pull request
May 26, 2024
when use java udf , we can put its jars in custom_lib of FE and BE in advance， and then we can create function without file property:
```
CREATE FUNCTION java_udf_add_one(int) RETURNS int PROPERTIES (
"symbol"="org.apache.doris.udf.AddOne",
"always_nullable"="true",
"type"="JAVA_UDF"
);
```
and we can use file property for custom jar:
```
CREATE FUNCTION java_udf_add_one(int) RETURNS int PROPERTIES (
"file"="file:///path/to/java-udf-demo.jar",
"symbol"="org.apache.doris.udf.AddOne",
"always_nullable"="true",
"type"="JAVA_UDF"
);
```
on FE, we use null location if the 'file' property is not set
on BE, we get jar path if both file path location and checksum are null
M1saka2003
pushed a commit
to M1saka2003/doris
that referenced
this pull request
May 27, 2024
when use java udf , we can put its jars in custom_lib of FE and BE in advance， and then we can create function without file property:
```
CREATE FUNCTION java_udf_add_one(int) RETURNS int PROPERTIES (
"symbol"="org.apache.doris.udf.AddOne",
"always_nullable"="true",
"type"="JAVA_UDF"
);
```
and we can use file property for custom jar:
```
CREATE FUNCTION java_udf_add_one(int) RETURNS int PROPERTIES (
"file"="file:///path/to/java-udf-demo.jar",
"symbol"="org.apache.doris.udf.AddOne",
"always_nullable"="true",
"type"="JAVA_UDF"
);
```
on FE, we use null location if the 'file' property is not set
on BE, we get jar path if both file path location and checksum are null
seawinde
pushed a commit
to seawinde/doris
that referenced
this pull request
May 27, 2024
when use java udf , we can put its jars in custom_lib of FE and BE in advance， and then we can create function without file property:
```
CREATE FUNCTION java_udf_add_one(int) RETURNS int PROPERTIES (
"symbol"="org.apache.doris.udf.AddOne",
"always_nullable"="true",
"type"="JAVA_UDF"
);
```
and we can use file property for custom jar:
```
CREATE FUNCTION java_udf_add_one(int) RETURNS int PROPERTIES (
"file"="file:///path/to/java-udf-demo.jar",
"symbol"="org.apache.doris.udf.AddOne",
"always_nullable"="true",
"type"="JAVA_UDF"
);
```
on FE, we use null location if the 'file' property is not set
on BE, we get jar path if both file path location and checksum are null
luzhijing
pushed a commit
to apache/doris-website
that referenced
this pull request
May 29, 2024
This was referenced Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
when use java udf , we can put its jars in custom_lib of FE and BE in advance， and then we can create function without file property:
and we can use file property for custom jar:
on FE, we use null location if the 'file' property is not set
on BE, we get jar path if both file path location and checksum are null
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...