Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[improvement](jdbc catalog) remove useless jdbc catalog code #34986

Merged
merged 3 commits into from
May 26, 2024
Merged

[improvement](jdbc catalog) remove useless jdbc catalog code #34986

merged 3 commits into from
May 26, 2024

Conversation

zy-kkk
Copy link
Member

@zy-kkk zy-kkk commented May 16, 2024 •
edited

Proposed changes

Issue Number: close #xxx

Since JdbcExecutor splitting for different data sources has been completed, I deleted the old JdbcExecutor code in this PR, and since the current reading of different data types is processed by each data source, we do not need to continue in BE Internal inspection is performed, so this part of the code is also deleted.In addition, since support for the nebula database Jdbc appearance is no longer needed, this part of the code has also been removed.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@zy-kkk
Copy link
Member Author

zy-kkk commented May 16, 2024

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 35.71% (9004/25216)
Line Coverage: 27.39% (74495/271961)
Region Coverage: 26.63% (38501/144557)
Branch Coverage: 23.47% (19643/83700)
Coverage Report: http://coverage.selectdb-in.cc/coverage/62ec37e8f71acfbb3b30f4e2ba2a0a771fa71c37_62ec37e8f71acfbb3b30f4e2ba2a0a771fa71c37/report/index.html

@zy-kkk
Copy link
Member Author

zy-kkk commented May 17, 2024

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 35.70% (9005/25224)
Line Coverage: 27.39% (74516/272070)
Region Coverage: 26.63% (38519/144618)
Branch Coverage: 23.48% (19662/83732)
Coverage Report: http://coverage.selectdb-in.cc/coverage/2e6217d66557bedd26eb0d68bef2b1169760ae20_2e6217d66557bedd26eb0d68bef2b1169760ae20/report/index.html

@zy-kkk
Copy link
Member Author

zy-kkk commented May 17, 2024

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@zy-kkk zy-kkk mentioned this pull request May 17, 2024
Closed
12 tasks
@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 35.70% (9006/25225)
Line Coverage: 27.37% (74474/272077)
Region Coverage: 26.62% (38512/144652)
Branch Coverage: 23.47% (19654/83754)
Coverage Report: http://coverage.selectdb-in.cc/coverage/b715f02c8a2c06c0dd41ad63cfc03c0ebbc8d4a1_b715f02c8a2c06c0dd41ad63cfc03c0ebbc8d4a1/report/index.html

morningman
morningman approved these changes May 26, 2024
View reviewed changes
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels May 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@zy-kkk zy-kkk merged commit 320b573 into apache:master May 26, 2024
27 of 30 checks passed
@zy-kkk zy-kkk deleted the del_jdbc_code branch May 26, 2024 13:53
M1saka2003 pushed a commit to M1saka2003/doris that referenced this pull request May 27, 2024
@zy-kkk @M1saka2003
[improvement](jdbc catalog) remove useless jdbc catalog code (apache#…
fb881b5 
…34986)
zy-kkk added a commit to zy-kkk/doris that referenced this pull request May 27, 2024
@zy-kkk
[improvement](jdbc catalog) remove useless jdbc catalog code (apache#…
b4b8ad2 
…34986)
@zy-kkk zy-kkk mentioned this pull request May 27, 2024
Merged
dataroaring pushed a commit that referenced this pull request May 27, 2024
@zy-kkk @dataroaring
[improvement](jdbc catalog) remove useless jdbc catalog code (#34986)
0f2d8c7
yiguolei pushed a commit that referenced this pull request May 27, 2024
@zy-kkk
[improvement](jdbc catalog) remove useless jdbc catalog code (#34986) (…
2e20e38 
…#35418)
@zy-kkk zy-kkk mentioned this pull request May 27, 2024
Merged
@zy-kkk zy-kkk removed the dev/2.1.x label May 27, 2024
seawinde pushed a commit to seawinde/doris that referenced this pull request May 27, 2024
@zy-kkk @seawinde
[improvement](jdbc catalog) remove useless jdbc catalog code (apache#…
8486ab0 
…34986)
zy-kkk added a commit that referenced this pull request May 28, 2024
@zy-kkk
[hotfix](jdbc table) Restoring a table type that should not be deleted (
80a68e3 
#35433)

prefix #34986 

We cannot directly delete fields in thrift, which will affect
enumeration errors caused by version inconsistencies between FE and BE
during upgrades.
dataroaring pushed a commit that referenced this pull request May 31, 2024
@zy-kkk @dataroaring
[hotfix](jdbc table) Restoring a table type that should not be deleted (
d19bf1f 
#35433)

prefix #34986 

We cannot directly delete fields in thrift, which will affect
enumeration errors caused by version inconsistencies between FE and BE
during upgrades.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morningman morningman morningman approved these changes

@wuwenchi wuwenchi wuwenchi approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.4-merged meta-change reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@zy-kkk @doris-robot @morningman @wuwenchi @yiguolei