Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[opt](memory) Add GlobalMemoryArbitrator and support ReserveMemory #34985

Merged
merged 5 commits into from
May 20, 2024
Merged

[opt](memory) Add GlobalMemoryArbitrator and support ReserveMemory #34985

merged 5 commits into from
May 20, 2024

Conversation

xinyiZzz
Copy link
Contributor

@xinyiZzz xinyiZzz commented May 16, 2024 •
edited

Proposed changes

Add GlobalMemoryArbitrator, used for check memory exceed limit, ReserveMemory

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@xinyiZzz
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 35.69% (9005/25231)
Line Coverage: 27.35% (74479/272273)
Region Coverage: 26.60% (38499/144752)
Branch Coverage: 23.42% (19637/83860)
Coverage Report: http://coverage.selectdb-in.cc/coverage/31b8edef78a097d4ac30649a0fb46437b4aa5d0f_31b8edef78a097d4ac30649a0fb46437b4aa5d0f/report/index.html

@xinyiZzz xinyiZzz force-pushed the 20240516_fix_memory_reserve branch 2 times, most recently from 86e3935 to a7a8557 Compare May 18, 2024 05:16
github-actions[bot]
github-actions bot reviewed May 18, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

be/src/runtime/memory/mem_tracker_limiter.h Outdated Show resolved Hide resolved
@xinyiZzz
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 35.70% (9011/25240)
Line Coverage: 27.36% (74511/272376)
Region Coverage: 26.61% (38540/144812)
Branch Coverage: 23.44% (19665/83892)
Coverage Report: http://coverage.selectdb-in.cc/coverage/2d8ed911cd501577c2b33995552277ab3793a820_2d8ed911cd501577c2b33995552277ab3793a820/report/index.html

yiguolei
yiguolei reviewed May 18, 2024
View reviewed changes
be/src/common/daemon.cpp Outdated Show resolved Hide resolved
@xinyiZzz xinyiZzz force-pushed the 20240516_fix_memory_reserve branch from 2d8ed91 to fecbe32 Compare May 18, 2024 16:39
@xinyiZzz
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 35.70% (9010/25240)
Line Coverage: 27.35% (74505/272394)
Region Coverage: 26.60% (38528/144815)
Branch Coverage: 23.43% (19660/83894)
Coverage Report: http://coverage.selectdb-in.cc/coverage/fecbe3204cc1092473d17895cc1b738ac5757f5e_fecbe3204cc1092473d17895cc1b738ac5757f5e/report/index.html

@xinyiZzz
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 35.70% (9011/25240)
Line Coverage: 27.35% (74507/272402)
Region Coverage: 26.61% (38538/144824)
Branch Coverage: 23.44% (19664/83900)
Coverage Report: http://coverage.selectdb-in.cc/coverage/778b81ef9a7f66b489fc8b31f590879289a78b3d_778b81ef9a7f66b489fc8b31f590879289a78b3d/report/index.html

@xinyiZzz xinyiZzz force-pushed the 20240516_fix_memory_reserve branch from 778b81e to b163895 Compare May 20, 2024 04:31
@xinyiZzz
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 35.70% (9010/25240)
Line Coverage: 27.35% (74502/272415)
Region Coverage: 26.60% (38532/144830)
Branch Coverage: 23.43% (19662/83904)
Coverage Report: http://coverage.selectdb-in.cc/coverage/b16389534f0c0f10ac5e77ca35b34e173c5c8f7d_b16389534f0c0f10ac5e77ca35b34e173c5c8f7d/report/index.html

yiguolei
yiguolei approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

mrhhsg
mrhhsg approved these changes May 20, 2024
View reviewed changes
Copy link
Member

@mrhhsg mrhhsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei yiguolei merged commit 84334a8 into apache:master May 20, 2024
24 of 28 checks passed
xinyiZzz added a commit to xinyiZzz/incubator-doris that referenced this pull request May 20, 2024
@xinyiZzz
[opt](memory) Add GlobalMemoryArbitrator and support ReserveMemory (a…
a009744 
…pache#34985)
@xinyiZzz xinyiZzz mentioned this pull request May 20, 2024
Merged
yiguolei pushed a commit that referenced this pull request May 22, 2024
@xinyiZzz
[opt](memory) Add GlobalMemoryArbitrator and support ReserveMemory (#…
2ed6a00 
…34985) (#35070)
M1saka2003 pushed a commit to M1saka2003/doris that referenced this pull request May 24, 2024
@xinyiZzz @M1saka2003
[opt](memory) Add GlobalMemoryArbitrator and support ReserveMemory (a…
852205d 
…pache#34985)
dataroaring pushed a commit that referenced this pull request May 26, 2024
@xinyiZzz @dataroaring
[opt](memory) Add GlobalMemoryArbitrator and support ReserveMemory (#…
3d3985b 
…34985)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions left review comments

@mrhhsg mrhhsg mrhhsg approved these changes

@yiguolei yiguolei yiguolei approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.4-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@xinyiZzz @doris-robot @mrhhsg @yiguolei