Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](hive-ctas) allow use qualified name when create hive table #34984

Merged
merged 1 commit into from
May 17, 2024

Conversation

morningman
Copy link
Contributor

@morningman morningman commented May 16, 2024

Proposed changes

issue #31442

Before, when executing create table hive.db.table as select to create table in hive catalog,
if current catalog is not hive catalog, the default engine name will be filled with olap, which is wrong.

This PR will fill the default engine name base on specified catalog.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@morningman morningman marked this pull request as ready for review May 16, 2024 16:04
@morrySnow morrySnow changed the title [fix](hive-ctas) allow use quolified name when create hive table [fix](hive-ctas) allow use qualified name when create hive table May 17, 2024
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 17, 2024
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

PR approved by anyone and no changes requested.

Copy link
Contributor

@kaka11chen kaka11chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morrySnow
Copy link
Contributor

run buildall

@morningman morningman merged commit be0edf6 into apache:master May 17, 2024
29 of 32 checks passed
yiguolei pushed a commit that referenced this pull request May 18, 2024
…34984)

Before, when executing `create table hive.db.table as select` to create table in hive catalog,
if current catalog is not hive catalog, the default engine name will be filled with `olap`, which is wrong.

This PR will fill the default engine name base on specified catalog.
M1saka2003 pushed a commit to M1saka2003/doris that referenced this pull request May 24, 2024
…pache#34984)

Before, when executing `create table hive.db.table as select` to create table in hive catalog,
if current catalog is not hive catalog, the default engine name will be filled with `olap`, which is wrong.

This PR will fill the default engine name base on specified catalog.
dataroaring pushed a commit that referenced this pull request May 26, 2024
…34984)

Before, when executing `create table hive.db.table as select` to create table in hive catalog,
if current catalog is not hive catalog, the default engine name will be filled with `olap`, which is wrong.

This PR will fill the default engine name base on specified catalog.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.4-merged dev/3.0.x reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants