Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use random port in registry IT #16014

Merged
merged 1 commit into from
May 17, 2024

Conversation

ruanwenjun
Copy link
Member

@ruanwenjun ruanwenjun commented May 16, 2024

Purpose of the pull request

  • Fix the UT will conflict with local port.
  • The UT failed frequently, I am not sure if this is due to the port conflict.

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@ruanwenjun ruanwenjun marked this pull request as draft May 16, 2024 10:24
@codecov-commenter
Copy link

codecov-commenter commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.58%. Comparing base (61915a2) to head (510ea75).

❗ Current head 510ea75 differs from pull request most recent head 0da8d38. Consider uploading reports for the commit 0da8d38 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##                dev   #16014   +/-   ##
=========================================
  Coverage     40.58%   40.58%           
- Complexity     5215     5216    +1     
=========================================
  Files          1380     1380           
  Lines         46056    46056           
  Branches       4916     4916           
=========================================
+ Hits          18692    18693    +1     
  Misses        25437    25437           
+ Partials       1927     1926    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ruanwenjun ruanwenjun marked this pull request as ready for review May 16, 2024 10:57
@ruanwenjun ruanwenjun added test bug Something isn't working labels May 16, 2024
@ruanwenjun ruanwenjun self-assigned this May 16, 2024
@ruanwenjun ruanwenjun added this to the 3.2.2 milestone May 16, 2024
@caishunfeng
Copy link
Contributor

Please add the purpose of the pull request.

@ruanwenjun
Copy link
Member Author

Please add the purpose of the pull request.

Done

@Radeity
Copy link
Member

Radeity commented May 17, 2024

Just curious, if the failure is due to port conflict, before this PR, it seems that UT will fail every time?

@ruanwenjun
Copy link
Member Author

Just curious, if the failure is due to port conflict, before this PR, it seems that UT will fail every time?

I see most fail case is the UT run on jdk8/jdk11 at the same time, then fail, retry one by one can success.

Copy link
Member

@Radeity Radeity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, LGTM.

Copy link

sonarcloud bot commented May 17, 2024

Please retry analysis of this Pull-Request directly on SonarCloud

Copy link
Contributor

@rickchengx rickchengx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rickchengx rickchengx merged commit 4e73fc2 into apache:dev May 17, 2024
61 of 63 checks passed
@ruanwenjun ruanwenjun deleted the dev_wenjun_useRanportPort branch May 31, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.2.2 backend bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants