[Improvment] improve resource service response #15997
Conversation
caishunfeng
changed the title
caishunfeng
force-pushed
the
improve/resource
branch
from
6fa3678
to
c5b1dbc
Compare
caishunfeng
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| */ | ||
| Result<Object> verifyResourceName(String fullName, ResourceType type, User loginUser); | ||
| void verifyResourceName(String fullName, ResourceType type, User loginUser); |
Check notice
Code scanning / CodeQL
Useless parameter Note
| void createDirectory(User loginUser, | ||
| String name, | ||
| ResourceType type, | ||
| int pid, |
Check notice
Code scanning / CodeQL
Useless parameter Note
| } | ||
| if (FileUtils.directoryTraversal(Objects.requireNonNull(file.getOriginalFilename()))) { | ||
| log.warn("File original name verify failed, fileOriginalName:{}.", | ||
| RegexUtils.escapeNRT(file.getOriginalFilename())); |
Check failure
Code scanning / CodeQL
Log Injection High
| if (!fileSuffix.equalsIgnoreCase(nameSuffix)) { | ||
| // rename file suffix and original suffix must be consistent | ||
| log.warn("Rename file suffix and original suffix must be consistent, fileOriginalName:{}.", | ||
| RegexUtils.escapeNRT(file.getOriginalFilename())); |
Check failure
Code scanning / CodeQL
Log Injection High
| log.warn( | ||
| "Resource file size is larger than max file size, fileOriginalName:{}, fileSize:{}, maxFileSize:{}.", | ||
| RegexUtils.escapeNRT(file.getOriginalFilename()), file.getSize(), Constants.MAX_FILE_SIZE); |
Check failure
Code scanning / CodeQL
Log Injection High
caishunfeng
force-pushed
the
improve/resource
branch
from
f25254c
to
3dea6db
Compare
Purpose of the pull request
Improve resource service response, avoid to use
Result<Object>Brief change log
ResourceServiceandResourceServiceImplVerify this pull request
update the UT
ResourcesServiceTest