-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor RowMutationInformation to use string type #31323
Refactor RowMutationInformation to use string type #31323
Conversation
...rm/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/AvroGenericRecordToStorageApiProto.java
Show resolved
Hide resolved
Assigning reviewers. If you would like to opt out of this review, comment R: @robertwb for label java. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #31323 +/- ##
============================================
+ Coverage 68.55% 71.02% +2.47%
+ Complexity 14921 2986 -11935
============================================
Files 2636 1067 -1569
Lines 222073 133554 -88519
Branches 11825 3241 -8584
============================================
- Hits 152234 94852 -57382
+ Misses 63644 35591 -28053
+ Partials 6195 3111 -3084
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add or update existing tests in StorageApiSinkRowUpdateIT? That class contains integration tests for RowMutationInformation. Would be good to have some real end-to-end tests to check this new behavior
@ahmedabu98 that test already covers the refactor behavior. For example, there's a call to |
@damondouglas Sorry I mean the new behavior of having multiple sections in the CSN (e.g. |
R: @ahmedabu98 |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
@ahmedabu98 I added the test cases but to keep things simple used |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the tests! this LGTM
Thank you, @ahmedabu98 . I will merge after checks pass. |
d4dcb27
to
31a91fd
Compare
FYI failing checks have nothing to do with code in the PR. Ran additional internal tests (see internal chat) and passed. |
This PR closes #31335 via refactoring BigQueryIO's assignment of the
_CHANGE_SEQUENCE_NUMBER
pseudo column from a long to fixed hex string.All BigQuery related tests for
./gradlew :sdks:java:io:google-cloud-platform:postCommit
and./gradlew :sdks:java:io:google-cloud-platform:build
passed on my local machine.Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.