Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trim the beam_ off the beginnings of job names #31275

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kennknowles
Copy link
Member

@kennknowles kennknowles commented May 13, 2024

Just a nit that drives my brain nuts. Also it scrolls more characters off the end of the job name so makes GitHub UI annoying.

Methodology:

  • search and replace beam_([A-Z]) and replace with $1
  • `rename -s beam_ '' * .github/workflows/*

The chance that this breaks something random where someone regexed against the job name is pretty high, though the global search shows nothing remains. But of course some bits won't use the repo as the source of truth. And probably some grafana queries need to be old job name OR new job name, etc, etc. And probably some ill-advised fragile uses that I miss in the above obvious stuff.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant