Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return psr/simple-cache v1 support #189

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TaProhm
Copy link

@TaProhm TaProhm commented Mar 24, 2022

Interface for psr/simple-cache has no breaking changes (with current implementation in mind) between v1 and v2: php-fig/simple-cache@1.0.1...2.0.0
Most changes in v2 are related to strong typing and the current implementation of PragmaRX\Countries\Package\Services\Cache\Service will work with both versions of psr/simple-cache.
Such versioning will allow to use this package with Laravel 8, which requires "psr/simple-cache": "^1.0"

Actually, Laravel 9 requirements are "psr/simple-cache": "^1.0|^2.0|^3.0". And v3 just adds return types for methods: php-fig/simple-cache@2.0.0...3.0.0
So, if you will NOT add types for methods parameters and will add return types, then such implementation of cache service will work with all current versions of psr/simple-cache

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant