refactor(docs-infra): notify on data change inside OnPush component #55830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkozlowski-opensource
added
action: review
JeanMeche
reviewed
May 16, 2024
adev/src/app/core/layout/secondary-navigation/secondary-navigation.component.ts
Show resolved
Hide resolved
The SecondaryNavigation component was updating state outside of an event handler without notifying about this change. Modeling state as signal should take care of proper UI updates (note that I did just a mechanical change here, maybe there are better ways of dealing with this animations case).
pkozlowski-opensource
force-pushed
the
adev_on_push_data_updates_1
branch
from
d82e81e
to
b087a1e
Compare
pkozlowski-opensource
removed
the
action: review
dylhunn
pushed a commit
that referenced
this pull request
May 21, 2024
…55830) The SecondaryNavigation component was updating state outside of an event handler without notifying about this change. Modeling state as signal should take care of proper UI updates (note that I did just a mechanical change here, maybe there are better ways of dealing with this animations case). PR Close #55830
|
This PR was merged into the repository by commit 831a20b. |
dylhunn
pushed a commit
that referenced
this pull request
May 21, 2024
…55830) The SecondaryNavigation component was updating state outside of an event handler without notifying about this change. Modeling state as signal should take care of proper UI updates (note that I did just a mechanical change here, maybe there are better ways of dealing with this animations case). PR Close #55830
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SecondaryNavigation component was updating state outside of an event handler without notifying about this change. Modeling state as signal should take care of proper UI updates (note that I did just a mechanical change here, maybe there are better ways of dealing with this animations case).