Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup dead jsnamespace code #55795

Closed
wants to merge 3 commits into from
Closed

Cleanup dead jsnamespace code #55795

wants to merge 3 commits into from

Conversation

rahatarmanahmed
Copy link
Contributor

Support for the jsnamespace attribute was removed in #55619.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

@rahatarmanahmed
refactor(core): Cleanup dead jsnamespace code
87a5a17 
Support for the jsnamespace attribute was removed in angular#55619.
@pullapprove pullapprove bot added the requires: TGP This PR requires a passing TGP before merging is allowed label May 14, 2024
@rahatarmanahmed rahatarmanahmed removed the request for review from thePunderWoman May 15, 2024 17:12
@rahatarmanahmed
Copy link
Contributor Author

TESTED=TGP

@rahatarmanahmed rahatarmanahmed requested review from tbondwilkinson and removed request for iteriani May 16, 2024 18:35
@rahatarmanahmed rahatarmanahmed added the action: merge The PR is ready for merge by the caretaker label May 16, 2024
@thePunderWoman thePunderWoman added the area: core Issues related to the framework runtime label May 16, 2024
@ngbot ngbot bot added this to the Backlog milestone May 16, 2024
@AndrewKushnir AndrewKushnir added the target: rc This PR is targeted for the next release-candidate label May 16, 2024
@dylhunn
Copy link
Contributor

dylhunn commented May 17, 2024

This PR was merged into the repository by commit f789488.

@dylhunn dylhunn closed this in f789488 May 17, 2024
dylhunn pushed a commit that referenced this pull request May 17, 2024
@rahatarmanahmed @dylhunn
refactor(core): Cleanup dead jsnamespace code (#55795)
239d4f0 
Support for the jsnamespace attribute was removed in #55619.

PR Close #55795
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbondwilkinson tbondwilkinson tbondwilkinson approved these changes

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime requires: TGP This PR requires a passing TGP before merging is allowed target: rc This PR is targeted for the next release-candidate
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rahatarmanahmed @dylhunn @tbondwilkinson @AndrewKushnir @thePunderWoman