Skip to content
This repository has been archived by the owner on Jun 14, 2022. It is now read-only.

Fix navigation bar icons legibility for API 26 and below #910

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alex-petrakov
Copy link

This fixes #507

It seems that devices running Android 8.0 (API 26) and below draw the navigation bar buttons using white or almost white color. At least, as mentioned in the linked issue, vanilla Android, Lineage OS, and EMUI do that.

To my understanding, the Android navigation bar wasn't supposed to have a light color until Android 8.1 (API 27) where a theme attribute android:lightNavigationBar was introduced, which allows to explicitly tell the system that we want the buttons to be drawn using a dark color.

So I propose:

  • For devices with API 26 and below change the navigation bar color to black so that white buttons become legible.
  • For devices with API 27 and above leave the navigation bar color as is.

All of the changes only affect the light theme.

Here is how the navigation bar would look before and after the changes on devices with API 26 and below:

Nav_bar_old

Nav_bar_new

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Navigation bar - light icons on light background
1 participant