Skip to content
This repository has been archived by the owner on Jun 14, 2022. It is now read-only.

Combined Nested if statements #697

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Combined Nested if statements #697

wants to merge 3 commits into from

Conversation

bd0n4lds
Copy link

Using codacy.com found if statements that could be combine.

@flocke flocke self-assigned this Nov 25, 2020
@flocke flocke added this to the v0.8.1 milestone Nov 25, 2020
@ziegenberg
Copy link
Contributor

There are six if statements combined, and about 80 other unrelated whitespace changes.

@bd0n4lds
Copy link
Author

There are six if statements combined, and about 80 other unrelated whitespace changes.

It was due to my Reformat Code running during my commit.

@ziegenberg
Copy link
Contributor

ziegenberg commented Jan 4, 2021

To not pollute commits with unrelated white space changes, maybe you want to clean up your commit?

@bd0n4lds
Copy link
Author

bd0n4lds commented Jan 8, 2021

Cleared up unrelated whitespace changes.

Copy link
Member

@flocke flocke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still some unrelated whitespace changes and it needs a rebase.

@flocke flocke modified the milestones: v0.8.1, v0.8.2 Mar 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants