Skip to content
This repository has been archived by the owner on Jun 14, 2022. It is now read-only.

refactoring and reducing warnings and alerts #588

Draft
wants to merge 28 commits into
base: master
Choose a base branch
from

Conversation

ziegenberg
Copy link
Contributor

@ziegenberg ziegenberg commented Jun 15, 2020

Reduce warnings and alerts from running code inspections.

Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
typo in string reference

Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
A static inner class does not keep an implicit reference to its enclosing instance. This prevents a common cause of memory leaks and uses less memory per instance of the class.

Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
…nio.charset.StandardCharsets.UTF_8

Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
@ziegenberg ziegenberg changed the title (not so) simple rework refactoring and reducing warnings and alerts Jan 5, 2021
Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>

remove unnecessary boxing and unboxing
Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
… and use Java 7 Automatic Resource Management

Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
 - BroadcastReceivedCallback()
 - Callable()
 - EncryptionChangeCallback()
 - OnActionSelectedListener()
 - OnClickListener()
 - OnItemClickListener()
 - OnLongClickListener()
 - OnMenuItemClickListener()
 - OnPreferenceChangeListener()
 - OnPreferenceClickListener()
 - PasswordEnteredCallback()
 - Runnable()
 - 'UnsupportedEncodingException'
 - 'InvalidAlgorithmParameterException'
 - 'IOException'

Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
 - Not annotated method overrides method annotated with @nonnull
 - Not annotated parameter overrides @nonnull parameter

Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants