add alibi position embedding and support baichuan #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add alibi position embedding
|
|
|
Cool! It may take some time to review 🙃 |
li-yi-dong
requested changes
Dec 19, 2023
megatron/model/transformer.py
Outdated
| @@ -471,10 +542,24 @@ def __init__(self, init_method, | |||
| self.core_attention = CoreAttention(self.layer_number, | |||
| self.attn_mask_type) | |||
| self.checkpoint_core_attention = args.recompute_granularity == 'selective' | |||
|
|
|||
| self.apply_query_key_layer_scaling = args.apply_query_key_layer_scaling | |||
| world_size = mpu.get_tensor_model_parallel_world_size() | |||
There was a problem hiding this comment.
tensor_parallel_size
sorry, I didn't get it. Do you mean the variance name should be tensor_parallel_size？
|
@li-yi-dong Thanks for your time and cautious review. I have made the necessary changes and addressed the comments you mentioned. Please take another look at the updated version at your convenience. |
li-yi-dong
reviewed
Dec 31, 2023
li-yi-dong
reviewed
Dec 31, 2023
li-yi-dong
reviewed
Dec 31, 2023
li-yi-dong
requested changes
Dec 31, 2023
| @@ -1222,11 +1286,106 @@ def set_input_tensor(self, input_tensor): | |||
| forward_step_func""" | |||
| self.input_tensor = input_tensor | |||
|
|
|||
| def _build_alibi_tensor(self, tensor, max_seq_len, num_attention_heads): | |||
There was a problem hiding this comment.
Placing this func together with alibi_mask_func
There was a problem hiding this comment.
This func requires the internal variable first_run, so it cannot be placed in the utils.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ALiBi method and its flash attention version (using triton) for positional information. And it supports baichuan model trainig by porting over the implementation from baichuan-inc/Baichuan2-13B-Base .