Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update storybook actions depth to 2 #6386

Merged
merged 3 commits into from
May 22, 2024
Merged

Update storybook actions depth to 2 #6386

merged 3 commits into from
May 22, 2024

Conversation

reidbarber
Copy link
Member

@reidbarber reidbarber commented May 15, 2024

This should help fix a noticeable lag after the Storybook 7 upgrade.

Note that the depth can be overridden at the individual action level, if we ever do want more depth for specific actions.

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

Test by opening a Combobox in storybook:

Before Change

After Change

🧢 Your Project:

RSP

@rspbot
Copy link

rspbot commented May 15, 2024

@adobe adobe deleted a comment from rspbot May 15, 2024
Copy link
Member

@snowystinger snowystinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't recall the reason I set this to 10 ages ago...

How'd you land on 2?
Button "press" still seems sluggish, and seems to go 3 deep? unless it's 0 indexed?
Screenshot 2024-05-16 at 9 56 36 AM

@reidbarber
Copy link
Member Author

reidbarber commented May 20, 2024

@snowystinger 2 seemed reasonable and performance was noticeably improved. I just tried 1 and it seems to behave the same as 2. I think this is a bug in 7.0: storybookjs/storybook#21933. I also tried 0 and it seems like the depth didn't apply at all in that case.

@rspbot
Copy link

rspbot commented May 20, 2024

@rspbot
Copy link

rspbot commented May 22, 2024

@rspbot
Copy link

rspbot commented May 22, 2024

## API Changes

unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any', access: 'private' }
unknown top level export { type: 'any', access: 'private' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'identifier', name: 'Column' }
unknown top level export { type: 'identifier', name: 'Column' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }

@reidbarber reidbarber merged commit c667db2 into main May 22, 2024
26 checks passed
@reidbarber reidbarber deleted the update-actions-depth branch May 22, 2024 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants