Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add .customize().add_cookie() #3215

Merged
merged 8 commits into from
Jun 7, 2024
Merged

feat: add .customize().add_cookie() #3215

merged 8 commits into from
Jun 7, 2024

Conversation

Thomblin
Copy link
Contributor

@Thomblin Thomblin commented Dec 4, 2023 •
edited by robjtede

PR Type

Feature

PR Checklist

  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • A changelog entry has been made for the appropriate packages.
  • Format code with the latest stable rustfmt.
  • (Team) Label with affected crates and semver status.

Overview

Added an add_cookie() method for HttpResponse(Responder).customize().

@Thomblin Thomblin mentioned this pull request Dec 4, 2023
Open
@robjtede robjtede added B-semver-minor A-web project: actix-web labels Dec 5, 2023
@robjtede robjtede enabled auto-merge June 7, 2024 15:22
robjtede
robjtede approved these changes Jun 7, 2024
View reviewed changes
Copy link
Member

@robjtede robjtede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

made some tweaks to fallibility but definitely worth adding this, thanks 👍🏻

@robjtede robjtede added this pull request to the merge queue Jun 7, 2024
Merged via the queue into actix:master with commit 534cfe1 Jun 7, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robjtede robjtede robjtede approved these changes

Assignees
No one assigned
Labels
A-web project: actix-web B-semver-minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Thomblin @robjtede