-
Notifications
You must be signed in to change notification settings - Fork 599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes to rename() #2854
Merged
Merged
Changes to rename() #2854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
istranical
requested changes
May 14, 2024
Quality Gate passedIssues Measures |
khustup2
approved these changes
May 22, 2024
activesoull
approved these changes
May 23, 2024
istranical
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 🚀 Pull Request
Impact
Description
Previously,
deeplake.rename()
anddataset.rename()
tried to rename both managed and unmanaged datasets.This PR removes the "rename" support for non-managed datasets, to avoid confusion on whether it does anything to the underlying storage or not. It's now purely a way to rename the URLs of a managed (
hub://
) dataset.It also adds the ability to just give the new name as the argument to rename rather than the whole new URL. So the new preferred syntax is:
deeplake.rename("hub://my_org/old_path", "new_path"
ordataset.rename("new_path")
. In either case the new URL will behub://my_org/new_path
Things to be aware of
That change does mean that you can't use deeplake.rename() to do a storage-level "move" anymore, but that was never the purpose of this method.