Issue 2348 #2349
Closed
Issue 2348 #2349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ColdWaterLW
reviewed
Apr 19, 2024
sqle/driver/plugin_manager.go
Outdated
|
|
||
| // 退出进程 | ||
| func KillProcess(process *os.Process) error { | ||
| err := process.Signal(syscall.SIGTERM) |
There was a problem hiding this comment.
这个方式可能无法终止假死的进程，建议等待一段时间，如果还没有退出，就用kill -9兜底
There was a problem hiding this comment.
2秒后若不能成功退出插件进程，则直接process.kill()
There was a problem hiding this comment.
err := process.Signal(syscall.SIGTERM) 这里如果卡住没有退出，是进不去case <-doneChan.C 这个case的，也就是2秒的定时不起作用
There was a problem hiding this comment.
process.Signal(syscall.SIGTERM)不会卡主，这里仅是向进程发送一个退出的信号，并不等待结果，process.Wait()才会阻塞
ColdWaterLW
reviewed
Jun 5, 2024
sqle/driver/plugin_manager.go
Outdated
| log.NewEntry().Warnf("get plugin %s process failed, error: %v", pluginPidFilePath, err) | ||
| } | ||
| if process != nil { | ||
| err = KillProcess(process) |
There was a problem hiding this comment.
极端情况下如果有多个插件需要kill，每个插件等待2秒，会拖慢sqle的启动速度，建议做成多个插件并发kill。参考使用waitgroup
|
commit信息不规范，切换分支，pr移至#2447 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
关联的 issue
#2348
描述你的变更
sqle启动插件逻辑，新增记录插件pid文件，kill残留插件进程逻辑
确认项（pr提交后操作）
Tip
请在指定复审人之前，确认并完成以下事项，完成后✅
not_compatibleneed_update_doc