Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added nicer frames for web and mobile #193

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Added nicer frames for web and mobile #193

wants to merge 1 commit into from

Conversation

Yusu-f
Copy link

@Yusu-f Yusu-f commented Dec 18, 2023 •
edited

I kept the total height of the frame the same so the viewable area is now slightly less. Closes #176

Screenshot 2023-12-19 at 10 16 11 AM Screenshot 2023-12-19 at 10 16 30 AM

@Yusu-f
Added nicer frames for web and mobile
d0ede2d 
I kept the total height of the frame the same so viewable area is now less. Also there's a small stutter in the mobile preview due to iframe content loading late, I'll try to find a workaround if necessary.
@Yusu-f Yusu-f closed this Dec 18, 2023
@Yusu-f Yusu-f reopened this Dec 18, 2023
@sweep-ai Sweep AI
Copy link
Contributor

sweep-ai bot commented Dec 18, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

@Yusu-f Yusu-f changed the title Added nicer frames for web and mobile Added nicer frames for web and mobile Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Elishiaaaaaa Elishiaaaaaa Elishiaaaaaa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a better looking frame for mobile and web previews
2 participants
@Yusu-f @Elishiaaaaaa