Introduce compilation mode #988
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dark64
reviewed
Nov 9, 2021
| let artifacts = check_with_arena(source, location.clone(), resolver, config, &arena)?; | ||
|
|
||
| match artifacts { | ||
| CompilationArtifacts::Lib => unreachable!(), |
There was a problem hiding this comment.
This might be reachable when called from zokrates-js because the config is passed by the caller:
If my understanding is correct, one could set the mode to lib and call compile which would throw here with no clear message.
dark64
reviewed
Nov 9, 2021
| @@ -162,9 +168,25 @@ impl fmt::Display for CompileErrorInner { | |||
| } | |||
| } | |||
|
|
|||
| #[derive(Debug, Serialize, Deserialize, Clone, Copy, PartialEq)] | |||
| pub enum CompileMode { | |||
| Bin, | |||
There was a problem hiding this comment.
I think we should use something like this here
#[derive(Debug, Serialize, Deserialize, Clone, Copy, PartialEq)]
pub enum CompileMode {
#[serde(rename = "bin")]
Bin,
#[serde(rename = "lib")]
Lib
}so it's a bit cleaner in js: mode: "lib" instead of mode: "Lib". It's also possible to put #[serde(rename_all = "lowercase")] before the enum definition.
We should also update typescript type information file:
https://github.com/Zokrates/ZoKrates/blob/add-compiler-mode-flag/zokrates_js/index.d.ts#L12
export type CompileMode = "bin" | "lib";
export interface CompileConfig {
allow_unconstrained_variables?: boolean,
isolate_branches?: boolean,
mode?: CompileMode
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks the file up to semantics, not requiring an entry point.