"Remove Link" option in the right-click context menu for links

[NMazzy]

Description

#5046 Adds a "Remove Link" option in the right-click context menu for links, which when clicked would remove the URL and associated markup from the markdown text, leaving only the text.

Changes

• Added a "menu.remove_link" field in the link right click context menu
• Created remove-markdown-link.ts file in markdown-editor/util

Additional information

Tested on:

• macOS Sonoma 14.1
• Ubuntu 22.04

[boring-cyborg]

Thank you for opening your first PR! 🎉 We are very happy and would like to thank you very much for your contribution. If everything checks out, we'll make sure to review the PR as soon as possible and give feedback. In the meantime, to make the reviewing process as fast as possible, you can help us by checking the following things:

• Did you follow the JSStandard coding style? - Did you comment everywhere where the necessity of a piece of code or the
  way it was implemented is not immediately obvious?
• Did you attempt to stick as much to current coding habits as possible?
  (Note that this does not apply to pieces of code where we ourselves
  obviously violated good coding practices, which unfortunately happens
  sometimes. But please indicate this in your PR so that we know what you
  rectified!)

Furthermore, make sure that the linter does not complain, which will check your code on every new commit. If the linter task fails, make sure to run yarn lint locally and check the file eslint_report.htm which will tell you precisely what went wrong.
Stay sharp, and thanks again!

[nathanlesage]

Thank you! Looks good so far -- just one comment: instead of slicing the entire node, you can also just search for the various child nodes that it should have. If I remember correctly, the link title that you want is not represented by its own node, instead you would have to check for two CodeMark nodes, and slice from the end of the first to the start of the second. That makes it more resilient to edge cases and leverages the parser more. I think I already implemented that snippet in the markdown AST parser module. I think searching for case 'Link' might turn it up

[MWBruce]

This has been implemented as suggested.

[nathanlesage]

Looks good. I found one issue while testing this out, though: It doesn't work with angle brackets links, i.e.:

This is some text with a plain link: <https://www.google.com>

Right-clicking that link will give you the option to remove a link, but it won't actually remove the angled brackets as I would expect it.

[NMazzy]

Looks good. I found one issue while testing this out, though: It doesn't work with angle brackets links, i.e.:

This is some text with a plain link: <https://www.google.com>

Right-clicking that link will give you the option to remove a link, but it won't actually remove the angled brackets as I would expect it.

I didn't even know this was a possible markdown link :)
This latest commit handles this case now.

[nathanlesage]

We're getting there! Just a few more things!

[NMazzy]

Hi @nathanlesage, I believe all your comments above, except the one regarding the reference style links have been implemented.

[MWBruce]

@NMazzy I think it might be @kyaso that is reviewing PR's at the moment.

[MWBruce]

@kyaso Further to a discord conversation I had with Nathan could you please advise if there is anything further required.

[kyaso]

Sorry for the late reply!

I just tested your PR locally, and it seems to do its job, so everything fine code-wise from my side.

One thing we should add is a Changelog entry (see https://github.com/Zettlr/Zettlr/blob/develop/CHANGELOG.md). You can add it under the "GUI and Functionality" section.

Once this has been done, I guess, @nathanlesage, we can merge?

[NMazzy]

Sorry for the late reply!

I just tested your PR locally, and it seems to do its job, so everything fine code-wise from my side.

One thing we should add is a Changelog entry (see https://github.com/Zettlr/Zettlr/blob/develop/CHANGELOG.md). You can add it under the "GUI and Functionality" section.

Once this has been done, I guess, @nathanlesage, we can merge?

Hi, a changelog entry has now been added under the "GUI and Functionality" section.

[nathanlesage]

Looks good for me, too, but the linter is complaining about an extra semicolon and about another issue (see the unit test) — once that's fixed we can merge. Thanks @kyaso for the code review!

[NMazzy]

Looks good for me, too, but the linter is complaining about an extra semicolon and about another issue (see the unit test) — once that's fixed we can merge. Thanks @kyaso for the code review!

Apologies should have checked this before hand, all should be fixed now.

[nathanlesage]

All good, no worries! I'll wait for the unit tests to finish and then merge it in! Thanks again for the work!

[boring-cyborg]

There we go, your PR got merged! Welcome to the party! 🔥