Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add checksum to PKGBUILD #218

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

harogaston
Copy link

I believe this should work to resolve #154 though I don't know how to test it locally. Uses https://github.com/marketplace/actions/publish-aur-package

@WillPower3309
Copy link
Owner

Hope you don't mind me requesting your review Erik! You have a lot more packaging experience than I

Copy link
Collaborator

@ErikReider ErikReider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure but I think that we'd need to update our secrets to match the ones required for the new action?

We'd also need to update the PKGBUILD in our repo for this to work. An example would be https://github.com/sane-fmt/sane-fmt/blob/c07ce4f09c0b8dfa902d28753ebb3800268183f5/template/sane-fmt-bin/PKGBUILD which also uses this action

@harogaston
Copy link
Author

Thank you for having a look at it! I repeat that I am not very proficient regarding packaging. Though I could not understand why would there be needed any changes to secrets since this affects only the checksum. And also didn't quite get why PKGBUILD requires any changes, I believe the checksum will be added by updpkgsums.

Sorry if I am completely in the wrong here. Just trying to explain why I did what I did and nothing else but I am not very knowledgeable on this topics so feel free to use it or discard it if it is very far off.

Cheers!

@ErikReider
Copy link
Collaborator

We should move this to https://github.com/wlrfx/aur-packages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide checksum in aur PKGBUILD (non -git)
3 participants