[WIP][Wasi] add Wasi-Socket

[LFsWang]

Wasi threads

framework

• resource manager
• access control
  • enable/disable network
  • network allow ip check

network

• network (resource)
  • instance
  • drop

udp-create-socket

• create_udp_socket(address-family)

udp

• udpsocket (resource)

  • instance
  • drop
  • subscribe (poll function, will remove in preview 3)
  • start_bind(address, address-family)
    • check ip is allowed
  • finish_bind(handle)
  • stream(remote-address)
    • check child stream (resource)
    • check remote address allowed
  • local_address()
  • remote_address()
  • AddressFamily()
  • UnicastHopLimit()
  • SetUnicastHopLimit()
  • GetReceiveBufferSize()
  • SetReceiveBufferSize()
  • GetSendBufferSize()
  • SetSendBufferSize()

• incoming-datagram-stream

  • instance (user can not use this)
  • drop
  • subscribe (poll function, will remove in preview 3)
  • receive(max-results)

• outgoing-datagram-stream

  • instance (user can not use this)
  • drop
  • subscribe (poll function, will remove in preview 3)
  • check-send()
  • send(list)

tcp-create-socket

• create_tcp_socket(address-family)

tcp

• tcp-socket
  • instance
  • drop
  • subscribe (poll function, will remove in preview 3)
  • start-bind
  • finish-bind
  • start-connect
  • finish-connect
  • start-listen
  • finish-listen
  • accept
  • local-address
  • remote-address
  • is_listening
  • address_family
  • set_listen_backlog_size
  • keep-alive-enabled
  • set-keep-alive-enabled
  • keep-alive-idle-time
  • setkeep-alive-idle-time
  • keep-alive-interval
  • set-keep-alive-interval
  • keep-alive-count
  • set-keep-alive-count
  • hop-limit
  • set-hop-limit
  • receive-buffer-size
  • set-receive-buffer-size
  • send-buffer-size
  • set-send-buffer-size
  • shutdown

IpNameLookup

• resolve-addresses
• resolve-address-stream
  • instance
  • drop
  • subscribe (poll function, will remove in preview 3)
  • resolve-next-address

[juntao]

Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR.

---

Commit acc7e23a2b1b8152ee7433f773790fd825d8c07a

The pull request "[WIP][Wasi] add Wasi-Socket" adds socket support to the Wasi (WebAssembly System Interface) in the WasmEdge project. The following are the major changes:

New headers files were added under the include/host/preview2/wasi-sockets/ directory, including api.h, base.h, env.h, etc. Each of these headers declares classes or types with corresponding functions for managing sockets.

New classes are implemented in 5 new source files under lib/host/preview2/wasi-sockets/ directory, including inode-linux.cpp, ipnamelookup.cpp, tcp.cpp, udp.cpp, and util.cpp. These classes handle udp/tcp sockets and utility functions.

There's an addition to the CMakeLists.txt file to handle the build configuration for the new code.

The critical file api.h provides robust error handling for sockets operations like access denied, invalid argument, operation timeout, concurrency conflict, etc. It also defines enums for Address family i.e., IPv4 and IPv6 and types for DGRAM and STREAM.

The env.h header file indicates an environment class WasiSocketsEnvironment has been added, which extends the WASI::Environ class.

The terms TCP, UDP, and IPNameLookup imply there is support for both UDP and TCP type sockets, and potential DNS resolution functionality.

Potential Issues:

1. This is a Work-In-Progress (WiP) and the code may not be ready for a production environment.

2. It's unclear whether there are corresponding unit tests to validate this new functionality.

3. Without comments in the code, it can be challenging to understand the purpose and functionality of some sections of code.

4. There might be potential issues with multi-threading as the resource table implementation is not thread-safe.

5. It's unclear how this integration has an impact on the overall performance of the software.

6. The PR does not delete any existing code which is a good sign. However, it might lead to breaks in other parts of the software that might use the previous implementation.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 1419 lines in your changes are missing coverage. Please review.

Project coverage is 73.21%. Comparing base (26de10d) to head (acc7e23).
Report is 3 commits behind head on master.

Files	Patch %	Lines
lib/host/preview2/wasi-sockets/tcp.cpp	0.00%	486 Missing ⚠️
lib/host/preview2/wasi-sockets/udp.cpp	0.00%	289 Missing ⚠️
lib/host/wasi/inode-linux.cpp	0.00%	269 Missing ⚠️
include/host/wasi/environ.h	0.00%	127 Missing ⚠️
include/host/preview2/wasi-sockets/util.h	0.00%	55 Missing ⚠️
include/host/wasi/vinode.h	0.00%	46 Missing ⚠️
lib/host/preview2/wasi-sockets/ipnamelookup.cpp	0.00%	44 Missing ⚠️
lib/host/preview2/wasi-sockets/util.cpp	0.00%	42 Missing ⚠️
...nclude/host/preview2/wasi-sockets/resource_table.h	0.00%	30 Missing ⚠️
include/host/preview2/wasi-sockets/env.h	0.00%	22 Missing ⚠️
... and 1 more

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3147      +/-   ##
==========================================
- Coverage   77.31%   73.21%   -4.11%     
==========================================
  Files         185      192       +7     
  Lines       25599    27018    +1419     
  Branches     5639     5999     +360     
==========================================
- Hits        19791    19780      -11     
- Misses       4382     5803    +1421     
- Partials     1426     1435       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.