Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix java code examples in README #3092

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Conversation

MichaelMorrisEst
Copy link
Contributor

Fixes #3091

Copy link
Member

juntao commented Dec 14, 2023

Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR.


@github-actions github-actions bot added the binding-java Java Bindings label Dec 14, 2023
@dannypsnl
Copy link
Member

dannypsnl commented Dec 15, 2023

It seems before this you need to fix the binding, from my check, the CI failed in a week.

@alabulei1
Copy link
Contributor

Hi @MichaelMorrisEst ,

Can you please check out the CI tests? Thanks.

@hydai
Copy link
Member

hydai commented Jun 4, 2024

Hi @MichaelMorrisEst
Please rebase to the latest master, GitHub doesn't allow me to merge this PR.

CleanShot 2024-06-05 at 03 33 30

@MichaelMorrisEst
Copy link
Contributor Author

Hi @hydai
PR is now rebased

@dannypsnl
Copy link
Member

Oops, we don't use merge, try rebase or cherry-pick again.

@hydai
Copy link
Member

hydai commented Jun 5, 2024

Hi @MichaelMorrisEst
I still cannot process the merge due to the following reason:

CleanShot 2024-06-05 at 11 38 55

It seems like the DCO check is not working. Could you please rebase and force-push the branch to trigger the DCO check again?

@MichaelMorrisEst MichaelMorrisEst force-pushed the issue-3091 branch 2 times, most recently from 95fe497 to 8797cb7 Compare June 5, 2024 09:30
@MichaelMorrisEst
Copy link
Contributor Author

Sorry, yes I did a merge rather than rebase. I have rebased now and force pushed, so hopefully all ok now

@hydai
Copy link
Member

hydai commented Jun 5, 2024

Hi @MichaelMorrisEst
I just realized that the DCO bot is stuck due to an upstream issue.
A workaround PR is merged: #3451
Please rebase again to ensure the DCO check is working. Thanks.

Signed-off-by: MichaelMorris <michael.morris@est.tech>
@hydai hydai merged commit 5eaf9ba into WasmEdge:master Jun 5, 2024
4 of 6 checks passed
@hydai
Copy link
Member

hydai commented Jun 5, 2024

Thanks @MichaelMorrisEst 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binding-java Java Bindings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Outdated README in java bindings
5 participants