-
Notifications
You must be signed in to change notification settings - Fork 715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix java code examples in README #3092
Conversation
Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR. |
It seems before this you need to fix the binding, from my check, the CI failed in a week. |
Hi @MichaelMorrisEst , Can you please check out the CI tests? Thanks. |
Hi @MichaelMorrisEst |
Hi @hydai |
Oops, we don't use merge, try rebase or cherry-pick again. |
Hi @MichaelMorrisEst It seems like the DCO check is not working. Could you please rebase and force-push the branch to trigger the DCO check again? |
95fe497
to
8797cb7
Compare
Sorry, yes I did a merge rather than rebase. I have rebased now and force pushed, so hopefully all ok now |
Hi @MichaelMorrisEst |
Signed-off-by: MichaelMorris <michael.morris@est.tech>
8797cb7
to
d1ea850
Compare
Thanks @MichaelMorrisEst 👍 |
Fixes #3091