Feature: pages sidebar collapsable and pin functionality in preview/release mode #9650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinning a menu once unpinned is difficult. Can we extend the onhover event to the pin button too Screen.Recording.2024-05-09.at.10.25.04.AM.mov |
|
The menu reset to pinned status once even if you have unpinned post reload |
|
Deployment: https://tooljet-pr-9650.onrender.com |
johnsoncherian
previously approved these changes
May 15, 2024
|
Deployment: https://tooljet-pr-9650.onrender.com |
|
Deployment: https://tooljet-pr-9650.onrender.com |
johnsoncherian
approved these changes
May 24, 2024
johnsoncherian
added a commit
that referenced
this pull request
May 30, 2024
* Remove date-fns depedency from table datepicker * Revert Remove date-fns depedency from table datepicker * Fix Built with Tooljet" watermark and app mode switcher appear briefly before the correct login page loads. (#9545) * fix: headers and action button UI on table (#9626) * fix: delete all children and nested children on component delete (#9182) * fix: delete all children and nested children on component delete * refactor: removed duplicate logics * refactor: reuse functions and remove duplicate functions * fix: update parentid of kanban modal child on version creation * fix: add kanban modal children to delete list * Fix duplicate text appearing at the bottom from the previous page in PDF widget (#9567) * chore: fixed vulnerability issues on FE (#9561) Co-authored-by: Johnson Cherian <johnsonc.dev@gmail.com> * chore: Removed unused packages in FE (#9161) * Removed unused packages * Remove date-fns dependency drom table date picker (#9585) --------- Co-authored-by: Johnson Cherian <johnsonc.dev@gmail.com> Co-authored-by: Nakul Nagargade <133095394+nakulnagargade@users.noreply.github.com> * Fix Pagination and order of rows malfunction if default selected Id is not on page 1 (#9651) * Fix Pagination and order of rows malfunction if default selected Id is not on page 1 * remove console logs * Add support to add Manual date entry in Datepicker table column (#9631) * Removed unused packages * Add Manual date entry in Datepicker table column * Remove date-fns dependency drom table date picker (#9585) * fix date input issue * Remove consoles --------- Co-authored-by: Kavin Venkatachalam <kavin.saratha@gmail.com> Co-authored-by: Johnson Cherian <johnsonc.dev@gmail.com> * Feature: pages sidebar collapsable and pin functionality in preview/release mode (#9650) * add: pin and collapsable functionality to pages sidebar * fix: review changes * fix: canvas auto update width on sidebar toggle * fix icon size * Add support to wrap table's column header (#9565) * Add support to wrap table's column header * Resolve code comments * commit * fix: resize page width on window resize (#9164) * feat: Button component revamp (#8361) * init textinput revamp * updated styles panel * bugfix * updates * fix :: accordion * fix :: styling * add box shadow , additional property,tooltip * fix conditional render for styles * feat :: fixed order of each property and styles * feat :: styling input * bugfix * feat :: add option to add icon * add option to add icon * adding option to toggle visibility * updated password input with new design * chnaging component location * bugfix * style fixes * fix :: added loader * updated :: few detailing * few bugfixes * fix :: for form widget label * fixes * added option to add icon color * including label field for password input * fix for label * fix * test fix backward compatibility for height * updates * revert * adding key for distinguishing older and newer widgets * testing * test * test * update * update * migration testing * limit vertical resizing in textinput * testing * throw test * test * adding check for label length * fixing edge cases * removing resize * backward compatibility height * backward compatibility * number input review fixes * added exposed items * fixing csa * ui fixes * fix height compatibility * feat :: csa for all inputs and exposed variables * backward compatibility fixes and validation fixes * fixes :: textinput positioning of loader and icon * fix :: password input * cleanup and fixes * fixes * cleanup * fixes * review fixes * review fixes * button component revamped * fix :: csa * typo fix * typo * fix :: styling * exposed variables * fix padding * review fixes styles component panel * fix naming * fix padding * default size * fix :: icons position * updates * cleanup * updates events , csa * cleanup * remove border * backward compatibility * clean * feat :: change validation from properties * ui fixes * icon name * disabled state * removed 'px' text from tooltip * fixes placeholder * few updates :: removing label in form * ui in form * update :: number input validation behaviour * testing fixes * added side handlers * removing unwanted fx * disabling fx for padding field * ordering change * fix * label issue + restricted side handler * fix :: box shadow bug * on change event doesnt propagate exposed vars correctly * adding debounce for slider value change * fix :: for modal ooen bug during onfocus event * test slider * fix :: bugs regarding state update in checbox , slider , slider bug * update slider with radix slider * bugfix * merge fixes * fix * updates * removing unwanted migrations * fix: box shadow * fix : import export issues * fix : colouring * cleanup * fixes * fix : design review comments * add border color * fix : review changes * fix * change display name to solid * fix label * fix : loader issue * fix : button icon position * fix : qa bugs * feat: Checkbox + Toggle revamp (#8519) * init textinput revamp * updated styles panel * bugfix * updates * fix :: accordion * fix :: styling * add box shadow , additional property,tooltip * fix conditional render for styles * feat :: fixed order of each property and styles * feat :: styling input * bugfix * feat :: add option to add icon * add option to add icon * adding option to toggle visibility * updated password input with new design * chnaging component location * bugfix * style fixes * fix :: added loader * updated :: few detailing * few bugfixes * fix :: for form widget label * fixes * added option to add icon color * including label field for password input * fix for label * fix * test fix backward compatibility for height * updates * revert * adding key for distinguishing older and newer widgets * testing * test * test * update * update * migration testing * limit vertical resizing in textinput * testing * throw test * test * adding check for label length * fixing edge cases * removing resize * backward compatibility height * backward compatibility * number input review fixes * added exposed items * fixing csa * ui fixes * fix height compatibility * feat :: csa for all inputs and exposed variables * backward compatibility fixes and validation fixes * fixes :: textinput positioning of loader and icon * fix :: password input * cleanup and fixes * fixes * cleanup * fixes * review fixes * review fixes * typo fix * fix padding * review fixes styles component panel * fix naming * fix padding * feat :: toggle switch revamp * init checkbox * fixes * fixes * switch fixes * validation fix * fixes * cleanup * height fix * fix height toggle * updates * fix :: icons position * updates * cleanup * updates events , csa * cleanup * backward compatibility * clean * backward compatibility fix * label fixed to one line * feat :: change validation from properties * ui fixes * icon name * removed 'px' text from tooltip * added onchange event for checkbox * fixes placeholder * few updates :: removing label in form * ui in form * fire onchange * update :: number input validation behaviour * testing fixes * added side handlers * removing unwanted fx * disabling fx for padding field * ordering change * fix * label issue + restricted side handler * fix :: box shadow bug * fix * on change event doesnt propagate exposed vars correctly * adding debounce for slider value change * fix :: for modal ooen bug during onfocus event * test slider * fix :: bugs regarding state update in checbox , slider , slider bug * update slider with radix slider * bugfix * update tooltip * fix toggle switch * fixes : inspector * fix : checkbox label * feat : checkbox completed * update checkbox review changes * feat : toggle component * feat : added new toggle component * fix : colors * updated review changes * update name for old and new version * update * case change * update * update icon * removed padding from checkbox and toggle * fix naming * product review and bugfixes : changes * fix : checkbox setvalue action * Update setvalue action in toggle * fixed: section for legacy and new components * fix : checkbox tick mark not showing on resizing * fix : icon in inspector * fix : box shadow * fix : ismandatory definition * configs update --------- Co-authored-by: Johnson Cherian <johnsonc.dev@gmail.com> * fix : toggle switch import and switch component issues (#9874) * fix : filter order of toggle (#9879) * fix: appbuilder 1.7 integration testing bug fixes (#9880) * fix: add only ids in deleted components map for component delete functionality * Fix TableRowHeightInput in codehinter (#9881) * fix: disable drag on calender popup and unblock other input interactions * Bugfixes componentes 1.7 (#9892) * fix : filter order of toggle (#9879) * fix : Button alignment when label is empty * fix : box shadow added * fix : direction and default box shadow * fix : disable csa not working for checkbox * fix : button padding * added toggle for box shadow check * fixes : integration 1.7 (#9901) * fix : exposed vars not getting exposed on page change * fix : validation error font * fix : dynamic color for button * fix : loading placement during CSA * Move disabled, visibility, tooltip and box shadow to properties in Checkbox and Button (#9665) * init textinput revamp * updated styles panel * bugfix * updates * fix :: accordion * fix :: styling * add box shadow , additional property,tooltip * fix conditional render for styles * feat :: fixed order of each property and styles * feat :: styling input * bugfix * feat :: add option to add icon * add option to add icon * adding option to toggle visibility * updated password input with new design * chnaging component location * bugfix * style fixes * fix :: added loader * updated :: few detailing * few bugfixes * fix :: for form widget label * fixes * added option to add icon color * including label field for password input * fix for label * fix * test fix backward compatibility for height * updates * revert * adding key for distinguishing older and newer widgets * testing * test * test * update * update * migration testing * limit vertical resizing in textinput * testing * throw test * test * adding check for label length * fixing edge cases * removing resize * backward compatibility height * backward compatibility * number input review fixes * added exposed items * fixing csa * ui fixes * fix height compatibility * feat :: csa for all inputs and exposed variables * backward compatibility fixes and validation fixes * fixes :: textinput positioning of loader and icon * fix :: password input * cleanup and fixes * fixes * cleanup * fixes * review fixes * review fixes * typo fix * fix padding * review fixes styles component panel * fix naming * fix padding * feat :: toggle switch revamp * init checkbox * fixes * fixes * switch fixes * validation fix * fixes * cleanup * height fix * fix height toggle * updates * fix :: icons position * updates * cleanup * updates events , csa * cleanup * backward compatibility * clean * backward compatibility fix * label fixed to one line * feat :: change validation from properties * ui fixes * icon name * removed 'px' text from tooltip * added onchange event for checkbox * fixes placeholder * few updates :: removing label in form * ui in form * fire onchange * update :: number input validation behaviour * testing fixes * added side handlers * removing unwanted fx * disabling fx for padding field * ordering change * fix * label issue + restricted side handler * fix :: box shadow bug * fix * on change event doesnt propagate exposed vars correctly * adding debounce for slider value change * fix :: for modal ooen bug during onfocus event * test slider * fix :: bugs regarding state update in checbox , slider , slider bug * update slider with radix slider * bugfix * update tooltip * fix toggle switch * fixes : inspector * fix : checkbox label * Move disabled, visibility, tooltip and box shadow to properties * Remove toggleswitch and button * Add down rollbackUpdates * fix : filter order of toggle (#9879) * fix merge issue * fix --------- Co-authored-by: stepinfwd <stepinfwd@gmail.com> * fix: use onMouseOver and onMouseLeave together to fix hover event * fix : Validation message to be shown only when use toggles on and off , code refactor (#9905) * Fix naming logic for copying (#9909) --------- Co-authored-by: Nakul Nagargade <133095394+nakulnagargade@users.noreply.github.com> Co-authored-by: Kiran Ashok <stepinfwd@gmail.com> * fix: update animateTransform for cross browser compatibility (#9917) * fix: color transitions on sidebar pages in dark mode (#9920) * Fix table all column editable (#9921) * fix: add only ids in deleted components map for component delete functionality * Fix TableRowHeightInput in codehinter (#9881) * fix: disable drag on calender popup and unblock other input interactions * Fix allColumns editable in Table * Fix clientServer nor working in Table * In widget config, update the total records as 10 --------- Co-authored-by: Johnson Cherian <johnsonc.dev@gmail.com> * chore: bump minor version --------- Co-authored-by: Nakul Nagargade <nakul@tooljet.com> Co-authored-by: Nakul Nagargade <133095394+nakulnagargade@users.noreply.github.com> Co-authored-by: vjaris42 <vjy239@gmail.com> Co-authored-by: Kavin Venkatachalam <50441969+kavinvenkatachalam@users.noreply.github.com> Co-authored-by: Kavin Venkatachalam <kavin.saratha@gmail.com> Co-authored-by: Kiran Ashok <stepinfwd@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #9290