Fix %%model and %model ipython magic error for seed model with csv column name with periods

[butchland]

• Add missing tests for %model and %%model line magic
  • add tests for full and view kind of models
  • add tests for seed model (happy path)
• Add test for seed model with period in column name
• Fix error for seed models with period in column name

[CLAassistant]

All committers have signed the CLA.

[butchland]

weird - the tests are failing on stuff I didn't touch. I thought removing the @pytest.mark.slow annotation would fix it but it seems not.
¯_(ツ)_/¯ I don't know what else to do get my PR accepted.

[georgesittas]

Hey @butchland, rebasing off of main should fix the CI issues. Can you share some context around this fix? What exactly was the issue / error you saw?

[butchland]

hi @georgesittas sorry for the late reply - here is a colab notebook showing the error that occurs when the seed data contains a csv file with a column name that has a period in it..

[georgesittas]

I see, thanks for sharing the notebook @butchland. I understand the issue now.

I don't think this approach to solving it is correct, though. Seeds with dots in the column names are perfectly legal, and we shouldn't just drop that information to make the parser happy. Also, this doesn't address similar issues with other "invalid" identifier characters.

The issue here is that we're trying to parse these names as if they are valid SQL, even though that's not really the case. The proper way to handle them is to parse them into identifiers, and if they contain any "special" characters, ensure that they are quoted. That way, we'll convert them to valid SQL.

[georgesittas]

I'll go ahead and close this PR for now, but I've opened a ticket to make sure this is tracked. We'll take a look soon, thanks for bringing this into our attention and appreciate the PR!