Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add smooth algorithm #11333

Closed

Conversation

mohmmadAyesh
Copy link

Describe your change:

  • [x ] Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • [ x] I have read CONTRIBUTING.md.
  • [ x] This pull request is all my own work -- I have not plagiarized.
  • [x ] I know that pull requests will not be merged if they fail the automated tests.
  • [ x] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • [ x] All new Python files are placed inside an existing directory.
  • [ x] All filenames are in all lowercase characters with no spaces or dashes.
  • [ x] All functions and variable names follow Python naming conventions.
  • [ x] All function parameters and return values are annotated with Python type hints.
  • [ x] All functions have doctests that pass the automated testing.
  • [ x] All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@mohmmadAyesh
Copy link
Author

@cclauss Hi can you review this PR or any of maintainer and merge if it has not required any further suggested changes?

@tianyizheng02
Copy link
Contributor

I found this GeeksforGeeks article with nearly identical code. The only differences appear to be comments and some function and variable names. I'm not flagging this as plagiarism right out of the gate because I can't definitively prove that the article was written before this PR was made, though this PR is still suspect.

@cclauss, thoughts on whether this should be flagged as plagiarism? If so, we can just close this PR. If not, I think we can let it pass with the caveat that the code must be refactored/rewritten and more thoroughly documented.

@cclauss cclauss closed this May 31, 2024
@tianyizheng02
Copy link
Contributor

I'll take this to mean that we're flagging this PR for plagiarism and add the appropriate tag

@tianyizheng02 tianyizheng02 added the Plagiarism!! This PR was found to be plagiarized label May 31, 2024
@mohmmadAyesh mohmmadAyesh deleted the add-smooth-algorithm branch May 31, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Plagiarism!! This PR was found to be plagiarized
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants